RUST-1109 Implement rawbson! and rawdoc! macros
#329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Dec 1, 2021
|
|
||
| // Finished with trailing comma. | ||
| (@array [$($elems:expr,)*]) => { | ||
| <$crate::RawArrayBuf as std::iter::FromIterator::<$crate::RawBson>>::from_iter(vec![$($elems,)*]) |
There was a problem hiding this comment.
This isn't as efficient as it could be, but it was a lot easier then rewriting this to build up the RawArrayBuf like we do for RawDocumentBuf. I field RUST-1118 to cover the work for doing this without the Vec allocation.
abr-egn
approved these changes
Dec 2, 2021
isabelatkinson
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1109
This PR implements the
rawbson!andrawdoc!macros to allow easier creation of raw BSON types. They are largely copy/pasted from the existingbson!anddoc!macros with just a few modifications to build raw BSON. This PR also updates a number of examples and tests to userawdoc!instead of buildingRawDocumentBufvalues manually or fromDocument.