Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

Conversation

@imlucas
Copy link
Contributor

@imlucas imlucas commented Mar 4, 2020

COMPASS-4191 notes:

vscode npm run package fails like so:
https://dev.azure.com/team-compass/vscode/_build/results?buildId=746&view=logs&j=291b3e6c-60a9-5f30-6b17-b27c7388dcd0&t=73e02479-b06a-558b-66de-a6177ecb9da0&l=63

ERROR  Command failed: npm list --production --parseable --depth=99999 --loglevel=error
npm ERR! missing: triejs@github:rueckstiess/triejs, required by [email protected]

The changes to triejs are minimal in the fork so I made @mongodb-js/triejs to remove the git:// dep complexity from our build toolchain.

While I'm in here, I've also done dependency updates, fixed tests, and added additional debugging for Compass' sake.

imlucas added 3 commits March 4, 2020 16:50
```
☉ [triejs] index-model/ ncu -u async lodash mongodb mongodb-js-errors mongodb-ns debug eslint-config-mongodb-js mocha mongodb-js-precommit mongodb-runner;
npm i;Upgrading /Users/lucas/index-model/package.json
[====================] 10/10 100%

 async                     ^1.5.2  →    ^3.2.0
 lodash                    ^4.8.2  →  ^4.17.15
 mongodb                   ^3.1.9  →    ^3.5.4
 mongodb-js-errors         ^0.4.0  →    ^0.5.0
 mongodb-ns                ^2.0.0  →    ^2.2.0
 debug                     ^2.2.0  →    ^4.1.1
 eslint-config-mongodb-js  ^3.0.1  →    ^5.0.3
 mocha                     ^5.2.0  →    ^7.1.0
 mongodb-js-precommit      ^2.0.0  →    ^2.2.1
 mongodb-runner            ^4.7.1  →    ^4.8.0
```
- `async@3` tasks in an `auto()` chain have callback and data args flipped from `[email protected]`
- `mongodb` prints warning unless `useUnifiedTopology: true` in `connect()`
- `mocha.opts` file is deprecated
- bring travis and npmignore templates up to date
@imlucas imlucas merged commit 6011d67 into master Mar 4, 2020
@imlucas imlucas deleted the triejs branch March 4, 2020 22:30
imlucas added a commit to mongodb-js/compass that referenced this pull request Mar 4, 2020
```
 mongodb                ^3.5.2  →   ^3.5.4
 mongodb-data-service  ^16.5.5  →  ^16.5.6
 mongodb-index-model    ^2.5.0  →   ^2.6.0
```

mongodb-js/index-model#62
mongodb-js/data-service#204
imlucas added a commit to mongodb-js/compass that referenced this pull request Mar 4, 2020
```
 mongodb                ^3.5.2  →   ^3.5.4
 mongodb-data-service  ^16.5.5  →  ^16.5.6
 mongodb-index-model    ^2.5.0  →   ^2.6.0
```

mongodb-js/index-model#62
mongodb-js/data-service#204
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants