This repository was archived by the owner on May 31, 2022. It is now read-only.
fix: set directConnection true on direct connections COMPASS-4534 #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-4534 and fixes https://github.com/mongodb-js/compass/issues/2075
Node driver 3.6.3 introduced a change where it no longer sets
directConnectionon the parsed connection string for single host connections with no supplied replica set:mongodb/node-mongodb-native@f8fd310
This PR introduces that behavior into our connect method so existing Compass connections are not broken.
Since tests in this module aren't very integrated with the driver (yet). We have some manual tests to run:
Before merging:
readPreference=secondary- I think it's another change we need to makeWe'll include an integration test for this behavior in the upcoming connectivity integration test epic.