fix(connection-model): directConnection and readPreference connectivity fix COMPASS-4539 COMPASS-4534 #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…direct-connection-fix
…tion-fix' of github.com:mongodb-js/compass into bump-connection-model-and-dataservice-for-direct-connection-fix
Anemy
changed the title
mcasimir
approved these changes
Dec 15, 2020
Anemy
deleted the
bump-connection-model-and-dataservice-for-direct-connection-fix
branch
Anemy
added a commit
that referenced
this pull request
Dec 16, 2020
…nnectivity fix COMPASS-4539 COMPASS-4534 (#2078)" This reverts commit b10a3df.
Anemy
added a commit
that referenced
this pull request
Dec 16, 2020
…nnectivity fix COMPASS-4539 COMPASS-4534 (#2078)" (#2082) This reverts commit b10a3df.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably want mongodb-js/data-service#280 in first and can also pull the bumped data service into compass then since it currently has connection model and mongodb version not as peer dependencies.
This pulls in mongodb-js/connection-model#337