Skip to content

allow using a TokioCommandWrap for TokioChildProcess::new closes #243 #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2025
Merged

allow using a TokioCommandWrap for TokioChildProcess::new closes #243 #245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb4fd7
allow using a TokioCommandWrap for TokioChildProcess::new closes #243
lucasfernog-crabnebula Jun 4, 2025
587903d
apply suggestion from code review
lucasfernog-crabnebula Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/rmcp/src/transport/child_process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,12 @@ impl AsyncRead for TokioChildProcessOut {
}

impl TokioChildProcess {
pub fn new(mut command: tokio::process::Command) -> std::io::Result<Self> {
command
pub fn new(command: impl Into<TokioCommandWrap>) -> std::io::Result<Self> {
let mut command_wrap = command.into();
command_wrap
Copy link
Collaborator

@jokemanfire jokemanfire Jun 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        let mut command_wrap = command.into();
        command_wrap
            .command_mut()
            .stdin(std::process::Stdio::piped())
            .stdout(std::process::Stdio::piped());

Copy link
Contributor Author

@lucasfernog-crabnebula lucasfernog-crabnebula Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed!

.command_mut()
.stdin(std::process::Stdio::piped())
.stdout(std::process::Stdio::piped());
let mut command_wrap = TokioCommandWrap::from(command);
#[cfg(unix)]
command_wrap.wrap(process_wrap::tokio::ProcessGroup::leader());
#[cfg(windows)]
Expand Down
Loading