allow using a TokioCommandWrap for TokioChildProcess::new closes #243 #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lcontextprotocol#243 TokioCommandWrap implements From<tokio::process::Command> so this is not a breaking change, but also downstream users have more control over flags such as KillOnDrop and CreationFlags see https://docs.rs/process-wrap/latest/process_wrap/#killondrop-and-creationflags
jokemanfire
reviewed
Jun 7, 2025
| .stdin(std::process::Stdio::piped()) | ||
| pub fn new(command: impl Into<TokioCommandWrap>) -> std::io::Result<Self> { | ||
| let mut command_wrap = command.into(); | ||
| command_wrap |
Collaborator
There was a problem hiding this comment.
let mut command_wrap = command.into();
command_wrap
.command_mut()
.stdin(std::process::Stdio::piped())
.stdout(std::process::Stdio::piped());
Contributor
Author
There was a problem hiding this comment.
pushed!
jokemanfire
approved these changes
Jun 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
we need to be able to set KillOnDrop and most importantly CreationFlags for the process spawned - we're now using process-wrap so we need to expose that interface
see https://docs.rs/process-wrap/latest/process_wrap/#killondrop-and-creationflags
How Has This Been Tested?
I'm working on an app that relies on CreationFlags - so i just tested it on Windows :)
Breaking Changes
TokioCommandWrap implements Fromtokio::process::Command so this is not a breaking change, but also downstream users have more control over flags such as KillOnDrop and CreationFlags
Types of changes
Checklist
Additional context