fix: sse endpoint build follow js's new URL(url, base)
#197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokemanfire
approved these changes
May 19, 2025
howardjohn
added a commit
to howardjohn/rust-sdk
that referenced
this pull request
Jun 17, 2025
This was broken by modelcontextprotocol#197. The URL join behaves like this: ``` $ let baseUrl = "https://example.com/sse"; $ new URL("?sessionId=x", baseUrl).href 'https://example.com/sse?sessionId=x' $ new URL("/?sessionId=x", baseUrl).href 'https://example.com/?sessionId=x' ``` The PR modelcontextprotocol#197 did not take into account the relative URL Fixes modelcontextprotocol#252
9 tasks
howardjohn
added a commit
to howardjohn/rust-sdk
that referenced
this pull request
Jun 18, 2025
This was broken by modelcontextprotocol#197. The URL join behaves like this: ``` $ let baseUrl = "https://example.com/sse"; $ new URL("?sessionId=x", baseUrl).href 'https://example.com/sse?sessionId=x' $ new URL("/?sessionId=x", baseUrl).href 'https://example.com/?sessionId=x' ``` The PR modelcontextprotocol#197 did not take into account the relative URL Fixes modelcontextprotocol#252
4t145
pushed a commit
that referenced
this pull request
Jun 19, 2025
* sse: fix regression in URL joining This was broken by #197. The URL join behaves like this: ``` $ let baseUrl = "https://example.com/sse"; $ new URL("?sessionId=x", baseUrl).href 'https://example.com/sse?sessionId=x' $ new URL("/?sessionId=x", baseUrl).href 'https://example.com/?sessionId=x' ``` The PR #197 did not take into account the relative URL Fixes #252 * Address review comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this client resolve the message endpoint
if sse_endpoint has this format:
<schema><authority?><sse_pq>,then the message endpoint will be
<schema><authority?><message_pq>.For example, if you config the sse_endpoint as
http://example.com/some_path/sse,and the server send the message endpoint event as
message?session_id=123,then the message endpoint will be
http://example.com/message.This follow the rules of JaveScript's
new URL(url, base)Motivation and Context
fix #196 #186 and all previous related issues.
How Has This Been Tested?
Breaking Changes
using the more proper names for SseClientConfig's fields:
Types of changes
Checklist
Additional context