sse: fix regression in URL joining #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-core
jokemanfire
reviewed
Jun 18, 2025
Collaborator
jokemanfire
left a comment
jokemanfire
left a comment
There was a problem hiding this comment.
I think wrap it as a func , It will be more conducive to maintenance.
Collaborator
|
cc @4t145 |
4t145
requested changes
Jun 18, 2025
This was broken by modelcontextprotocol#197. The URL join behaves like this: ``` $ let baseUrl = "https://example.com/sse"; $ new URL("?sessionId=x", baseUrl).href 'https://example.com/sse?sessionId=x' $ new URL("/?sessionId=x", baseUrl).href 'https://example.com/?sessionId=x' ``` The PR modelcontextprotocol#197 did not take into account the relative URL Fixes modelcontextprotocol#252
howardjohn
force-pushed
the
sse/join-url-path
branch
from
deed3d7 to
f009e8e
Compare
jokemanfire
approved these changes
Jun 19, 2025
4t145
approved these changes
Jun 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This was broken by
#197.
The URL join behaves like this:
The PR #197 did not take into account the relative URL
Fixes #252
How Has This Been Tested?
Yes, tested with agentgateway.dev which was broken by this change.
Breaking Changes
Types of changes
Checklist
Additional context