-
Notifications
You must be signed in to change notification settings - Fork 989
Refactor notification handling to include all notifications #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor notification handling to include all notifications #191
Conversation
|
Thanks for making changes. Did you get a chance to test this after switching to use the specific notification types? For a similar PR we had been using |
|
It looks like we may need to add handling for |
|
I previously said
But, @olaservo you mentioned automated testing, so I'm not certain putting these in the Well, we could send periodic But it would be useful to make the long running process simulation in the |
cliffhall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
|
can we have this merged ? |
|
Thanks @cliffhall for thinking through the testing approach here. I was tinkering with some sort of integration tests too earlier on which would simulate some of these scenarios.
Yes agree that seems like something that would be worthwhile for providing a 'live' example of cancelling, as a separate PR. |
|
Added an issue to the servers repo for handling cancellation. Will need to add one to this repo as well, for tracking the id and exposing a cancel button. |
Refactor notification handling to include all notifications
This fixes #190
Motivation and Context
Previously, not all notifications were displayed, leading to potential missed updates and crucial information.
How Has This Been Tested?
On any notification


Error warning no impact / change
Breaking Changes
Nope
Types of changes
Checklist
Additional context