Skip to content

Conversation

@IanMatthewHuff
Copy link
Member

Porting this PR to release branch:

#7153

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

* close restart session right away

* ignore errors on await, don't want to stop and wait for shutdown
@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #7161 into release will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #7161      +/-   ##
===========================================
- Coverage    58.48%   58.43%   -0.06%     
===========================================
  Files          485      485              
  Lines        21437    21437              
  Branches      3462     3462              
===========================================
- Hits         12537    12526      -11     
- Misses        8122     8135      +13     
+ Partials       778      776       -2
Impacted Files Coverage Δ
src/client/common/logger.ts 68.55% <0%> (-6.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 732c987...28a6835. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit a29ca3f into microsoft:release Aug 30, 2019
kimadeline added a commit that referenced this pull request Sep 4, 2019
* add cron job to nightly tests (#7128) (#7158)
* close restart session right away (#7153) (#7161)
* close restart session right away
* ignore errors on await, don't want to stop and wait for shutdown
* Release changes (#7183)
* Update package version
@lock lock bot locked as resolved and limited conversation to collaborators Sep 6, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/leak-release-port branch July 9, 2020 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants