Skip to content

Conversation

@IanMatthewHuff
Copy link
Member

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Aug 28, 2019
@IanMatthewHuff
Copy link
Member Author

Even after adding it back in the UI AzDO still seems to be ignoring the UI added schedule for the Nightly build. Some docs seem to imply this is expected, which others seem to imply that while cron is encouraged the UI schedules should still work.

https://docs.microsoft.com/en-us/azure/devops/release-notes/2019/sprint-153-update#use-cron-syntax-to-specify-schedules-in-a-yaml-file

Going forward you won't be able to add or update schedules that have been created using the UI editor. We will continue to honor those schedules for some time, but we recommend that you remove them from the UI and add them to the YAML file.

https://developercommunity.visualstudio.com/content/problem/608227/unable-to-schedule-builds-in-azure-devops-ui.html

As per new experience, we will give preference to traditional schedules in editor if there are any and not use cron schedules at that time. If you delete all schedules from editor, the next update to yaml file will start using cron schedules in it. User can switch to traditional schedules anytime by just adding them back in editor.

pr: none

schedules:
- cron: "0 0 * * 1-5"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda new to the syntax here, this is what I used to check it.
https://crontab.guru/#0_0_*_*_1-5

@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #7128 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7128      +/-   ##
==========================================
- Coverage   58.46%   58.43%   -0.04%     
==========================================
  Files         485      485              
  Lines       21437    21437              
  Branches     3462     3462              
==========================================
- Hits        12533    12526       -7     
- Misses       8123     8135      +12     
+ Partials      781      776       -5
Impacted Files Coverage Δ
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd76e60...cccbe37. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit f3a55af into microsoft:master Aug 28, 2019
IanMatthewHuff added a commit to IanMatthewHuff/vscode-python that referenced this pull request Aug 30, 2019
kimadeline added a commit that referenced this pull request Sep 4, 2019
* add cron job to nightly tests (#7128) (#7158)
* close restart session right away (#7153) (#7161)
* close restart session right away
* ignore errors on await, don't want to stop and wait for shutdown
* Release changes (#7183)
* Update package version
@lock lock bot locked as resolved and limited conversation to collaborators Sep 4, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/nightlyCronJob branch July 9, 2020 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants