Skip to content

Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' with correct value: 'grid'" (And add MessagingExtensionAttachmentLayout) #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2025
Merged

Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' with correct value: 'grid'" (And add MessagingExtensionAttachmentLayout) #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4f48fe
Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' wit…
heyitsaamir Oct 27, 2025
3711a31
Add MessageExtensionAttachmentLayout
heyitsaamir Oct 27, 2025
9ce6c02
It's messagING not Message!
heyitsaamir Oct 28, 2025
f5a4836
Forgot index
heyitsaamir Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/api/src/models/attachment/attachment-layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export type AttachmentLayout = 'list' | 'grid';
export type AttachmentLayout = 'list' | 'carousel';
1 change: 1 addition & 0 deletions packages/api/src/models/messaging-extension/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ export * from './messaging-extension-parameter';
export * from './messaging-extension-query';
export * from './messaging-extension-action';
export * from './messaging-extension-action-response';
export * from './messaging-extension-attachment-layout';
1 change: 1 addition & 0 deletions packages/api/src/models/messaging-extension/messaging-extension-attachment-layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export type MessagingExtensionAttachmentLayout = 'list' | 'grid';
6 changes: 3 additions & 3 deletions packages/api/src/models/messaging-extension/messaging-extension-result.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Activity } from '../../activities';
import { AttachmentLayout } from '../attachment';

import { MessagingExtensionAttachment } from './messaging-extension-attachment';
import { MessagingExtensionAttachmentLayout } from './messaging-extension-attachment-layout';
import { MessagingExtensionSuggestedAction } from './messaging-extension-suggested-action';

/**
Expand All @@ -27,10 +27,10 @@ export type MessagingExtensionResultType =
*/
export type MessagingExtensionResult = {
/**
* @member {AttachmentLayout} [attachmentLayout] Hint for how to deal with
* @member {MessagingExtensionAttachmentLayout} [attachmentLayout] Hint for how to deal with
* multiple attachments. Possible values include: 'list', 'grid'
*/
attachmentLayout?: AttachmentLayout;
attachmentLayout?: MessagingExtensionAttachmentLayout;

/**
* @member {MessagingExtensionResultType} [type] The type of the result. Possible values include:
Expand Down