Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' with correct value: 'grid'" (And add MessagingExtensionAttachmentLayout) #382
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h correc…" This reverts commit e60c260.
heyitsaamir
changed the title
corinagum
previously approved these changes
Oct 27, 2025
aacebo
reviewed
Oct 27, 2025
packages/api/src/models/messaging-extension/messaging-extension-result.ts
Outdated
Show resolved
Hide resolved
aacebo
previously approved these changes
Oct 27, 2025
heyitsaamir
changed the title
corinagum
approved these changes
Oct 29, 2025
aacebo
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #381
This is a bit of mess -
AttachmentLayoutthat exists onActivitywhich should belist | carousel.AttachmentLayoutthat exists onMessageExtensionwhich should belist | grid.