Skip to content

Remove references to hermes-engine-darwin #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 25, 2022
Merged

Remove references to hermes-engine-darwin #956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7f78c36
Remove hermes-engine-darwin, update generator-macos
Saadnajmi Jan 15, 2022
bde4ad3
fix typo
Saadnajmi Jan 15, 2022
5606612
one postinstall
Saadnajmi Jan 15, 2022
714aa7a
remove test targets
Saadnajmi Jan 16, 2022
dade965
disable flipper
Saadnajmi Jan 16, 2022
6224289
minimal changes to podfile
Saadnajmi Jan 16, 2022
63507c0
one less diff
Saadnajmi Jan 16, 2022
b85d664
Merge branch 'main' of git://github.com/microsoft/react-native-macos …
Saadnajmi Jan 25, 2022
5bb20d5
Updatee from PR comments
Saadnajmi Jan 25, 2022
a716f05
Update local-cli/generator-macos/templates/macos/Podfile
Saadnajmi Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions local-cli/generator-macos/templates/macos/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,8 @@ target 'HelloWorld-macOS' do
use_native_modules!
use_react_native!(
:path => '../node_modules/react-native-macos',

# To use Hermes, install the `hermes-engine-darwin` npm package, e.g.:
# $ yarn add 'hermes-engine-darwin@~0.5.3'
#
# Then enable this option:
# :hermes_enabled => true
# to enable hermes on macOS, change `false` to `true` and then install pods
:hermes_enabled => false
)

# Pods specifically for macOS target
Expand All @@ -29,7 +25,6 @@ target 'HelloWorld-iOS' do
use_flipper!

post_install do |installer|
flipper_post_install(installer)
react_native_post_install(installer)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
end
Expand Down
1 change: 0 additions & 1 deletion repo-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"eslint-plugin-react-native": "3.10.0",
"eslint-plugin-relay": "1.8.1",
"flow-bin": "^0.158.0",
"hermes-engine-darwin": "~0.5.0",
"jest": "^26.6.3",
"jest-junit": "^10.0.0",
"jscodeshift": "^0.11.0",
Expand Down
5 changes: 0 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4306,11 +4306,6 @@ has@^1.0.3:
dependencies:
function-bind "^1.1.1"

hermes-engine-darwin@~0.5.0:
version "0.5.3"
resolved "https://registry.yarnpkg.com/hermes-engine-darwin/-/hermes-engine-darwin-0.5.3.tgz#4eb8edabfff640c2150cf974290a03429b66cc11"
integrity sha512-TwCpLJgEDm/Z2pOr88IDlXlC1Y3WITvXoYtOr4iChc6ecJqYOUklQW838lKZ7urBBFfPb0rW6poVD6iZORdzZQ==

hermes-engine@~0.9.0:
version "0.9.0"
resolved "https://registry.yarnpkg.com/hermes-engine/-/hermes-engine-0.9.0.tgz#84d9cfe84e8f6b1b2020d6e71b350cec84ed982f"
Expand Down