Remove references to hermes-engine-darwin #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeyImChris
approved these changes
Jan 17, 2022
kelset
approved these changes
Jan 17, 2022
tido64
reviewed
Jan 18, 2022
tido64
reviewed
Jan 18, 2022
…into remove-hermes-engine-darwin
tido64
reviewed
Jan 25, 2022
Co-authored-by: Tommy Nguyen <[email protected]>
tido64
approved these changes
Jan 25, 2022
kelset
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
As of facebook/hermes#639
hermes-engine-darwinno longer exists, and macOS should use the standardhermes-enginethat is shared with iOS. This change updates our template to reflect that.I also updated
local-cli/generator-macos/templates/macOS/Podfileto more closely matchtemplate/ios/Podfile.Changelog
[macOS] [Removed] - Remove references to hermes-engine-darwin
Test Plan
CI Passing should be enough to verify the template still works.
hermesas of now doesn't work on macOS, so that's still a WIP.