-
Notifications
You must be signed in to change notification settings - Fork 149
chore: merge up to 0.79-stable branch #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: Pull Request resolved: facebook#49423 Changelog: [Internal] Reviewed By: huntie Differential Revision: D69655570 fbshipit-source-id: bd9b3dbc70b93c5be49e6a2b1b0487d11bf5b3f1
…49480) Summary: Pull Request resolved: facebook#49480 Changelog: [Internal] Reviewed By: huntie Differential Revision: D69752685 fbshipit-source-id: 94f70eeaec35c864c15b463f3afce929765f2c40
Summary: Migrate com.facebook.react.uimanager.ReactClippingViewGroup to Kotlin ## Changelog: [INTERNAL] - Migrate com.facebook.react.uimanager.ReactClippingViewGroup to Kotlin Pull Request resolved: facebook#49413 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: rshest Differential Revision: D69750532 Pulled By: cortinico fbshipit-source-id: 50ec87a71b3bd523e1a9518b8bd683a027a4b422
Summary: Pull Request resolved: facebook#49491 Changelog: [General][Breaking] Deep imports to modules inside `Libraries/DevMenu` using `require` may need to be appended with `.default` Reviewed By: cortinico Differential Revision: D69778671 fbshipit-source-id: 19362fbb003e53609881fc19e8d2cb96677b3006
Summary: This task is unused, so we can safely remove it here. ## Changelog: [INTERNAL] - Remove unused Gradle task `packageReactNdkLibsForBuck` Pull Request resolved: facebook#49493 Test Plan: N/A Reviewed By: cipolleschi Differential Revision: D69781945 Pulled By: cortinico fbshipit-source-id: cd6487faf1d169f44590a26c18a9f35eef803617
Summary: Pull Request resolved: facebook#49484 This is the last diff to add support for Gradle Configuration caching. The last missing part here was the execution of the `config` command during Gradle configuration time. Using Java processes API is not supported as the correct way to do external commands that are CC-friendly is through the `.providers.exec` API which I'm using here. Closes facebook#45154 Changelog: [Android] [Added] - Add support for Gradle Configuration caching Reviewed By: cipolleschi Differential Revision: D69753889 fbshipit-source-id: af1e844b38444659a908abce4029d43ad899c03d
…acebook#49266) Summary: Pull Request resolved: facebook#49266 Changelog: [Internal] - Aligned types of the PushNotificationIOS between Flow and TS Reviewed By: huntie Differential Revision: D69309391 fbshipit-source-id: 1e99f6aa6805c25db7ede6c65305b309590ebd6a
Summary: Pull Request resolved: facebook#49463 We've started accumulating mode-files in many different directories, group them all under xplat/mode/react-native for consistency Changelog: [Internal] Reviewed By: lenaic Differential Revision: D69658995 fbshipit-source-id: 70c842d24886b9b0ef8432d105ca64cac68078db
…ok#49440) Summary: Pull Request resolved: facebook#49440 changelog: [internal] move away from RCTUnsafeExecuteOnMainQueueSync in RCTSafeArea. Reviewed By: javache, lenaic Differential Revision: D69662510 fbshipit-source-id: c68e42d6787b1a60ecba46d774ada40163de83fe
Summary: Pull Request resolved: facebook#49448 I noticed that when inset shadows have a smaller blur radius than spread its wrong and there is a gap between the edge of the box and the shadow. I think the outer rect is just defined incorrectly and we should be adjusting the paddingBox as opposed to the innerRect. The innerRect is just the padding box insetted by the spread, so that is why we see gaps if blur < spread Changelog: [Android][Fixed] - Fix inset boxShadow when blur < spread Reviewed By: jorge-cab Differential Revision: D69688508 fbshipit-source-id: 911258edd9a8403c70992800c3e1a5ea044e1f3b
Summary: Pull Request resolved: facebook#49507 Implement getDelegateMethod on ReactPopupMenuManager changelog: [internal] internal Reviewed By: shwanton Differential Revision: D69807880 fbshipit-source-id: b0168454b24a1af4e99a46e8c70ebb70162c19d0
Summary: Changelog: [Internal] Reviewed By: gkz Differential Revision: D69816782 fbshipit-source-id: c4d1e7bff3333fe8075816542d0b316408363f86
Summary: Pull Request resolved: facebook#49503 Relanding this change, now checking for the existing of FeatureFlags native module before checking it, with the assumption when the native module is unavailable (legacy arch) we will never do native processing, or even use the SVC. This aligns with the approach taken in `setupTimers` for the event loop, but is probably not the right long term solution for flags API. This also inlines a couple fixes originally up the stack, of missing propagation of inline state, and missing the gating in ReactNativeStyleAttributes. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69804412 fbshipit-source-id: 1f285994132cff75b6845b64cf26fceae37d4c92
…#49504) Summary: Pull Request resolved: facebook#49504 We didn't have these cases before. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69433955 fbshipit-source-id: 3915b63ec6972412f1882d796ae60035bb5192f3
Summary: Pull Request resolved: facebook#49505 I want to go home 😭. This is not very pretty, while we are both keeping the old path, and trying to keep the props data types undisturbed for now, and support some of the stranger syntax we ended up supporting as inputs to filters. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69562718 fbshipit-source-id: db8ff2c240b66e93a52ce2ac98e4a9ff2e7aeb4b
Summary: Pull Request resolved: facebook#49418 This adds some missing validation for negative blurs which should be considered parse error. Unit tests added for the forked props parsing code to validate more generally. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69628917 fbshipit-source-id: 1451b53cfa673443f01d38bd0097c4e85c83db8b
…acebook#49500) Summary: Pull Request resolved: facebook#49500 changelog: [internal] When crossing ScrollView boundary, cullingContext.transform must be reset to Transform.identity. Views are only culled within scroll view. Reviewed By: NickGerleman Differential Revision: D69787820 fbshipit-source-id: 5d502f764a2b1885ee4b49fc0c9ebb9d27de65dd
Summary: Pull Request resolved: facebook#49475 changelog: [internal] RCTNetworking does not need main thread setup, it doesn't access any main thread only resources. Reviewed By: rshest Differential Revision: D69744400 fbshipit-source-id: 25652c28d178a9e26fa0ede9b03fb87072094fb0
Summary: Pull Request resolved: facebook#49424 Changelog: [Internal] Reviewed By: huntie Differential Revision: D69655561 fbshipit-source-id: c36036a2abb43dd75c41582f2a27e7f9d3509044
Summary: Pull Request resolved: facebook#49495 This change extracts the dependencies array to a separate file. This is helpful because we can use this file as cache-key to determines whether we have to rebuild the artifacts or not. This file is also bound to grow so it will make the script more manageable. ## Changelog: [Internal] - Move the dependencies for ios prebuilds on a separate file Reviewed By: cortinico Differential Revision: D69779522 fbshipit-source-id: 7ce60e426d428859f6f759d8e7b1ea499c36eff9
…#49496) Summary: Pull Request resolved: facebook#49496 This change prepare the argument parsing to the prepare-ios-prebuilds so we can customise the behavior to simplify usage in CI. It also adds the --help command to provide. ##changelog: [Internal] - adds the help mfunction and argument parsing Reviewed By: cortinico Differential Revision: D69779877 fbshipit-source-id: d66bc19ee556229eb7167f2075b77bacce2ad5c4
Summary: Pull Request resolved: facebook#49497 This change honors the task provided as an argument. If `all` is passed, we execute all the commands. If a specific task is passed, we only execute that command. ## Changelog: [Internal] - Honor the task passed to the preopare-ios-script Reviewed By: cortinico Differential Revision: D69787470 fbshipit-source-id: 0dec13ad0b5f2cc23cc72b4a899405ac1acf4f86
Summary: Pull Request resolved: facebook#49469 This PR updates the changelog for 0.78 by combining all the RC into 0.78.0 stable, in preparation of the release in a couple of days. This also adds categories to the commits and sort them alphabetically. ## Changelog: [Internal] - Update vchangelog for 0.78 Reviewed By: cortinico, fabriziocucci Differential Revision: D69745703 fbshipit-source-id: 825190c7a9573939ec7f1e388448142f8a8caf25
…ain thread setup (facebook#49473) Summary: Pull Request resolved: facebook#49473 changelog: [internal] Add RCTTraitCollectionProxy which synchronises access to current trait collection. This way, RCTAppearance does not need main thread setup and RCTUnsafeExecuteOnMainQueueSync Reviewed By: javache Differential Revision: D69750211 fbshipit-source-id: 8457904fa1672d4bf811c04ef69969a8f8f4d87f
Summary: Pull Request resolved: facebook#49474 changelog: [internal] Can move setup to the background setup: 1. Use RCTTraitCollectionProxy to access current trait collection to check if force touch is available. 2. UIDevice.currentDevice is thread safe and can be read safely from a background thread. Reviewed By: rshest Differential Revision: D69744257 fbshipit-source-id: 8857a827c3d3e03a9b2ced15e6970d728693a043
) Summary: Pull Request resolved: facebook#49476 changelog: [internal] Introduce RCTInitialAppStateProxy to access app initial state in thread safe way. Reviewed By: javache Differential Revision: D69745459 fbshipit-source-id: f88a04774e064bf13904183aa3334f93cbcc5283
…49494) Summary: Pull Request resolved: facebook#49494 Changelog: [Internal] Reviewed By: huntie Differential Revision: D69786939 fbshipit-source-id: 3b0481e83a528afbdf1d29734d2aea9cad740f58
Summary: Pull Request resolved: facebook#49492 Was looking at more places we could be using `HybridClassBase`, and figured out how to simplify ReadableMapBuffer constructors to remove the need for explicit soloading. Changelog: [Android][Removed] `RuntimeExecutor` and `RuntimeScheduler` constructors are now private, `MapBufferSoLoader` was removed as no longer required. Reviewed By: cortinico Differential Revision: D69776110 fbshipit-source-id: 11eac4c59897a02283e021ac1457ef8299b6f480
…book#49498) Summary: Pull Request resolved: facebook#49498 This change handles the destinations and the configurations parameter when passed to the script. ## Changelog: [Internal] - Handle `configuration` and `destination` parameters Reviewed By: cortinico Differential Revision: D69787469 fbshipit-source-id: 5c4ae766dad84640fbf5340efc296355c4944e1c
Summary: As part of the initiative to reduce the public API surface, this classes can be internalized. I've checked there are no relevant OSS usages: - [RCTLog](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+com.facebook.react.util.RCTLog) - [ExceptionDataHelper](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+com.facebook.react.util.ExceptionDataHelper) ## Changelog: [INTERNAL] - Make RCTLog & ExceptionDataHelper internal Pull Request resolved: facebook#49502 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: rshest Differential Revision: D69836482 Pulled By: cortinico fbshipit-source-id: 16f37acbd77bf151126bff22a6010201d8174bea
Commenter does not have sufficient privileges for PR 2620 in repo microsoft/react-native-macos |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
f91681a
to
8b0856e
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
hello any news on this? when can we use 0.79 version with macos? we have windows app using 0.79 and we would like to create the app for macos as well but there is inconsistency between latest versions. |
Working on these next few weeks. This PR is step 1 of a new release. |
thank you for your answer! can you give us any eta when can we start using 0.79 ? |
I have found predicting the future to be folly, so no, sadly |
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
...eactCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/HostPlatformColor.mm
Outdated
Show resolved
Hide resolved
...eactCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/HostPlatformColor.mm
Outdated
Show resolved
Hide resolved
...eactCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/HostPlatformColor.mm
Outdated
Show resolved
Hide resolved
...eactCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/HostPlatformColor.mm
Show resolved
Hide resolved
packages/react-native/React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingView.mm
Show resolved
Hide resolved
193b380
to
79a5aed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase the "Fix flow checks" into the big merge commit? I think we're good to go after that :)
79a5aed
to
89f1399
Compare
Done! |
Summary:
Merge up to the first commit on
0.79-stable
branch from upstream (81e4901).Full list files where conflicts had to be manually resolved
Test Plan:
Run RNTester locally