-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Add box shadow examples which use objects and PlatformColor #49504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D69433955 |
Summary: Relanding this change, now checking for the existing of FeatureFlags native module before checking it, with the assumption when the native module is unavailable (legacy arch) we will never do native processing, or even use the SVC. This aligns with the approach taken in `setupTimers` for the event loop, but is probably not the right long term solution for flags API. This also inlines a couple fixes originally up the stack, of missing propagation of inline state, and missing the gating in ReactNativeStyleAttributes. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69804412
…#49504) Summary: We didn't have these cases before. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69433955
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 18, 2025
…#49504) Summary: We didn't have these cases before. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69433955
b5196c7
to
3f8b4c8
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 18, 2025
…#49504) Summary: We didn't have these cases before. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69433955
This pull request was exported from Phabricator. Differential Revision: D69433955 |
3f8b4c8
to
1ea762b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 18, 2025
…facebook#49504) Summary: We didn't have these cases before. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69433955
This pull request was exported from Phabricator. Differential Revision: D69433955 |
This pull request has been merged in b91565d. |
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
…#49504) Summary: Pull Request resolved: facebook#49504 We didn't have these cases before. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D69433955 fbshipit-source-id: 3915b63ec6972412f1882d796ae60035bb5192f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We didn't have these cases before.
Changelog: [Internal]
Reviewed By: joevilches
Differential Revision: D69433955