Skip to content

Conversation

NickGerleman
Copy link
Contributor

Summary:
We didn't have these cases before.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D69433955

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 18, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69433955

Summary:

Relanding this change, now checking for the existing of FeatureFlags native module before checking it, with the assumption when the native module is unavailable (legacy arch) we will never do native processing, or even use the SVC.

This aligns with the approach taken in `setupTimers` for the event loop, but is probably not the right long term solution for flags API.

This also inlines a couple fixes originally up the stack, of missing propagation of inline state, and missing the gating in ReactNativeStyleAttributes.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D69804412
…#49504)

Summary:

We didn't have these cases before.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D69433955
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Feb 18, 2025
…#49504)

Summary:

We didn't have these cases before.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D69433955
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Feb 18, 2025
…#49504)

Summary:

We didn't have these cases before.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D69433955
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69433955

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Feb 18, 2025
…facebook#49504)

Summary:

We didn't have these cases before.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D69433955
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69433955

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b91565d.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 19, 2025
gabrieldonadel pushed a commit to gabrieldonadel/react-native that referenced this pull request Aug 12, 2025
…#49504)

Summary:
Pull Request resolved: facebook#49504

We didn't have these cases before.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D69433955

fbshipit-source-id: 3915b63ec6972412f1882d796ae60035bb5192f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants