This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Sparse simulator (core components) #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial sparse simulator commit * Updated copyright message * Formatted readme.md * Formatted readme.md and fixed typo * Removed #pragma once in .cpp files * Collapsed nested namespace definitions using :: * Replaced defines with constexpr * Replaced tabs with spaces * Updated message and comment * Rearranged headers, include path in tests * Marshall boolean C++ return to C# * Rename parity function * Renamed reserved identifiers * Renamed AND, hashmap comments, fix cmake * Made unit tests work. Added comments * Updated SparseSimulator comment * Some build fixes * Changed amplitude probes to assertions, removed dependencies, used internal keyword * Replacing flat_hash_map with std::unordered_map * Iterator dereference fix * Removed parallel execution * Added C++17 standard missing in Release * Removed unused files and references * Apply suggestions from code review Co-authored-by: Thomas Haener <[email protected]> * Review feedback and exclusion from build Co-authored-by: Sam Jaques <[email protected]> Co-authored-by: Dmitry Vasilevsky <[email protected]> Co-authored-by: bettinaheim <[email protected]> Co-authored-by: Thomas Haener <[email protected]>
* Added building SparseSimulator without Cake. * Updated the README.md, removed build.cake * Added SparseSimulator to CI build and test Co-authored-by: Stefan J. Wernli <[email protected]>
Update Sparse Simulator to use Catch2 for testing.
* Removed probes.qs * Test project builds (though some tests are still commented out) (#846) * Moving tests, lib instead of exe Co-authored-by: bettinaheim <[email protected]>
* Changing qubit type in sparse simulator, attempt 1 * Updated C# interface code to use IntPtr for qubit id Co-authored-by: Dmitry Vasilevsky <[email protected]>
…rgeMain Merging `main` to `feature/sparse-simulator`
bettinaheim
commented
Feb 16, 2022
bettinaheim
commented
Feb 16, 2022
bettinaheim
commented
Feb 16, 2022
bettinaheim
commented
Feb 16, 2022
bettinaheim
commented
Feb 16, 2022
bettinaheim
commented
Feb 16, 2022
src/Simulation/Simulators/SparseSimulatorDeprecated/SparseSimQSharpTests/Program.qs
Outdated
Show resolved
Hide resolved
bettinaheim
commented
Feb 16, 2022
src/Simulation/Simulators/SparseSimulatorDeprecated/SparseSimQSharpTests/RemovedTests.qs
Outdated
Show resolved
Hide resolved
bettinaheim
commented
Feb 16, 2022
src/Simulation/Simulators/SparseSimulatorDeprecated/SparseSimulatorCS/Probes.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@kuzminrobin My comments here are addressed with this PR: #940. |
kuzminrobin
approved these changes
Feb 16, 2022
Contributor
Author
|
e2e build failure is expected, since this feature requires updates to the build logic as well. The updates on all feature branches including the updates to the build logic has been confirmed separately via the release pipeline. |
This was referenced Feb 17, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes all user facing components of the sparse simulator.
Predecessor PR (see the checkmarks in the description)
Parallel PRs:
Q#RT
Q#Compiler
Quantum
iqsharp
QuantumLibraries
qdk