This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 90
Sparse Simulator #918
Merged
Merged
Sparse Simulator #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
commented
Jan 26, 2022
Comment on lines
72
to
73
| //string sparseSimulatorName, // TODO(rokuzmin): Requires support in Q# compiler? | ||
| // Is invoked from the .cs code generated from .qs, and the arg for this param is not provided. |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamarSha, @bettinaheim, please advise regarding this fragment and please confirm that the changes in EntryPointDriver are correct (after I uncomment them).
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be postponed to a subsequent PR.
cgranade
reviewed
Jan 26, 2022
kuzminrobin
commented
Jan 26, 2022
This was referenced Jan 27, 2022
Open
be53a70 to
1a7dcd0
Compare
msoeken
reviewed
Feb 8, 2022
This was referenced Feb 10, 2022
thomashaener
approved these changes
Feb 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little of history.
Some time ago the QuantumSimulator has been broken up into
CommonNativeSimulator (common for QuantumSimulator and SparseSimulator)
and QuantumSimulator (inheriting from CommonNativeSimulator).
Now in this PR
The new class SparseSimulator2 inherits from the CommonNativeSimulator (by example of QuantumSimulator).
The native part of the earlier SparseSimulator relocates to a separate directory NativeSparseSimulator (by example of the native full-state simulator)
So now the sparse simulator consists of NativeSparseSimulator (C++) and SparseSimulator2 (C#).
The remaining part of the earlier SparseSimulator will be removed when the SparseSimulator2 is fully integrated. Then the SparseSimulator2 will be renamed to SparseSimulator.
Related PRs:
In this PR:
kuzminrobin/sparseSimtofeature/sparse-simulatorin this PR and in QuantumLibraries, iqsharp, Quantum, qdk.Next PR(s):
feature/sparse-simulatortomain(Sparse simulator (core components) #939)DumpMachine()has been tested during SS demo, see TASK 37776. PR)Other PRs: