Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@kuzminrobin
Copy link
Contributor

@kuzminrobin kuzminrobin commented Jan 26, 2022

A little of history.
Some time ago the QuantumSimulator has been broken up into
CommonNativeSimulator (common for QuantumSimulator and SparseSimulator)
and QuantumSimulator (inheriting from CommonNativeSimulator).

Now in this PR
The new class SparseSimulator2 inherits from the CommonNativeSimulator (by example of QuantumSimulator).
The native part of the earlier SparseSimulator relocates to a separate directory NativeSparseSimulator (by example of the native full-state simulator)
So now the sparse simulator consists of NativeSparseSimulator (C++) and SparseSimulator2 (C#).

The remaining part of the earlier SparseSimulator will be removed when the SparseSimulator2 is fully integrated. Then the SparseSimulator2 will be renamed to SparseSimulator.

Related PRs:

In this PR:

  • Fix all tests
  • Rename the older SparseSimulator to SparseSimulatorDeprecated
  • Rename SparseSimulator2 to SparseSimulator
  • Rename folder and file SparseSimulator2 to SparseSimulator
  • Build qdk.release successfully for this branch
  • Merge kuzminrobin/sparseSim to feature/sparse-simulator in this PR and in QuantumLibraries, iqsharp, Quantum, qdk.

Next PR(s):

Other PRs:

  • Add the SparseSimulator to all the documentation (TASK 37112) (https://github.com/MicrosoftDocs/quantum-docs-private/pull/732)
  • Add the static and dynamic analysis to the native part of the SS, and probably add more native tests with the analysis enabled (some .qs test intermittently crashes in CI on Linux only (search for "crash"), does not repro in WSL, Win)

Comment on lines 72 to 73
//string sparseSimulatorName, // TODO(rokuzmin): Requires support in Q# compiler?
// Is invoked from the .cs code generated from .qs, and the arg for this param is not provided.
Copy link
Contributor Author

@kuzminrobin kuzminrobin Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamarSha, @bettinaheim, please advise regarding this fragment and please confirm that the changes in EntryPointDriver are correct (after I uncomment them).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be postponed to a subsequent PR.

@kuzminrobin kuzminrobin merged commit 94fc56b into feature/sparse-simulator Feb 11, 2022
@kuzminrobin kuzminrobin deleted the kuzminrobin/sparseSim branch February 15, 2022 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants