Add mimalloc.h to usr/local/include when installing #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jul 8, 2019
include/mimalloc-types.h
Outdated
| mi_page_flags_t flags; | ||
| uint16_t capacity; // number of blocks committed | ||
| uint16_t reserved; // numbes of blocks reserved in memory | ||
| uint16_t reserved; // numbers of blocks reserved in memory |
Collaborator
|
Ah thanks! However, I think the readme is wrong -- it should install to |
Author
|
Hi @daanx ! or (I preferred this one, since the 1.0 is not for good.) or, just leave it to you? : ) |
daanx
added a commit
that referenced
this pull request
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In readme, we know that when installing the header files should be installed in usr/local/include.
But, it does not do that in current version which leads to
failed.
So, I add a line in Cmakelists.txt to correct it!