Make install places files in invalid paths

[kfir-drivenets]

After cloning the repo, building and running make install the project is not properly installed.

Commands:

cd ./mimalloc
mkdir -p out/release
cd out/release
cmake ../../
make
make install

Resulting installation:

root@153362c728c0:/usr/local/lib# ls -R mimalloc-1.6/
mimalloc-1.6/:
cmake  include  libmimalloc.a  libmimalloc.so  libmimalloc.so.1.6  mimalloc.o

mimalloc-1.6/cmake:
mimalloc-config-version.cmake  mimalloc-config.cmake  mimalloc-release.cmake  mimalloc.cmake

mimalloc-1.6/include:
mimalloc-new-delete.h  mimalloc-override.h  mimalloc.h

[daanx]

Thanks. However, it looks good to me? There should be a symlink in /usr/local/lib called libmimalloc.so that points to the one in the versioned directory. On my machine it looks like:

> dev/mimalloc-bench/out/bench$ ls -lag /usr/local/lib
total 0
drwxr-xr-x 1 root  4096 Mar  6 17:19 .
drwxr-xr-x 1 root  4096 Sep 15  2019 ..
lrwxrwxrwx 1 root    37 Mar  6 17:19 libmimalloc-debug.so -> mimalloc-1.6/libmimalloc-debug.so.1.6
drwxr-xr-x 1 root  4096 Sep 15  2019 mimalloc-1.0
drwxr-xr-x 1 root  4096 Oct 12 10:44 mimalloc-1.1
drwxr-xr-x 1 root  4096 Nov 22 09:13 mimalloc-1.2
drwxr-xr-x 1 root  4096 Jan 15 10:52 mimalloc-1.3
drwxr-xr-x 1 root  4096 Jan 20 15:08 mimalloc-1.4
drwxr-xr-x 1 root  4096 Feb  1 13:41 mimalloc-1.5
drwxr-xr-x 1 root  4096 Mar  6 17:19 mimalloc-1.6

Maybe I misunderstood?

[kfir-drivenets]

make install shouldn't copy the mimalloc-1.6/cmake or mimalloc-1.6/include: into /usr/local/lib.
The cmake shouldn't be copied anywhere and the include files should be in /usr/local/include/

[andronat]

I have the same issue as @kfir-drivenets reports. Headers are in the wrong directory.

[elbaro]

See this patch:
https://github.com/conda-forge/mimalloc-feedstock/blob/master/recipe/0001-update-install-path-patch.patch

This installs

# .
# ├── include
# │  ├── mimalloc-new-delete.h
# │  ├── mimalloc-override.h
# │  └── mimalloc.h
# └── lib
#    ├── libmimalloc.a
#    ├── libmimalloc.so -> libmimalloc.so.1.6
#    ├── libmimalloc.so.1.6
#    └── mimalloc.o

To support multiple minor versions, we can have

#    ├── libmimalloc.so.1.6 -> libmimialloc.so.1.6.2
#    ├── libmimalloc.so.1.6.2

[daanx]

Thanks @elbaro. I will look into it. However, this still leaves out the cmake files; it seems those are needed for correct version detection by cmake if someone REQUIREs mimalloc. If we don't install those, how can cmake find them? (assuming one does not build mimalloc itself).

Also, this leaves the headers, archive, and .o unversioned. The current structure has everything for a specific version.

[elbaro]

cmake - Installing cmake files is what other packages do too, I think it's fine.
https://stackoverflow.com/questions/55845401/where-should-cmake-files-be-installed

.h - it's good to have versioned headers if you want, but it should be under /usr/include/, not /usr/lib/.

I recommend to have versioned filenames and also unversioned symlink.

e.g.

#include <mimalloc.h>  // symlink
#include <mimalloc-1.5/mimalloc.h> // if want a specific version
#include <mimalloc/mimalloc-1.5.h> // or
#include <mimalloc.1.5.h> // or