Zerryth/dialog prompts #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…botbuilder-python into Zerryth/DialogPrompts
|
Per chat with @axelsrz, going to abandon work on OAuthPrompt, as he will be working on that himself 👍 |
…botbuilder-python into Zerryth/DialogPrompts
…botbuilder-python into Zerryth/DialogPrompts
…from varios constructors
…ut Find class & choice tokenizer
Tests for activity prompt.
…botbuilder-python into axsuarez/DialogPrompts Merge with Zerryth's branch
tests for tokenizer
… into Zerryth/DialogPrompts
tests for find methods
|
@axelsrz I would move this out of Draft into actual full-fledged PR, since prompts and choices are finally ready! I'll talk to you in-person tomorrow :) |
axelsrz
approved these changes
Jul 3, 2019
libraries/botbuilder-dialogs/botbuilder/dialogs/choices/choice_recognizers.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/prompt.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185, #186, #197
Description
Adding missing prompts and choices-related classes into Python repo:
ActvityPromptAttachmentPromptChoicePrompt(Work in Progress)ChoiceRecognizers(Work in Progress)FindFindChoicesOptionsFindValuesOptionsFoundChoiceModelResultSortedValueTokenTokenizerTurnContextalso no longer will hard-codeActivity.input_hintto always beacceptingInput--only when none is set, will it default toacceptingInput