-
Notifications
You must be signed in to change notification settings - Fork 305
Closed
Labels
P1Painful if we don't fix, won't block releasingPainful if we don't fix, won't block releasing
Description
Version
preview 2
Describe the bug
In botbuilder-dotnet and botbuilder-js repos, the TurnContext class allows the user to set the value of activity.input_hint.
-
dotnet: has 2
SendActivityAsync()methods:- if the prompt is just a text, then to allow
inputHintparameter & create an activity to send with the text andinputHint - if the prompt is an
Activity, then to just send the activity through--if change inActivity.InputHintis desired, then it must be changed on the activity itself, before passing intoSendActivityAsync()method
- if the prompt is just a text, then to allow
-
js: has 1
.sendActivity()method whose first parameter can be eitherstringorActivityand as a separate parameter acceptsinputHint- creates an activity within that one method, using the
inputHintarg passed in or if it's anActivity, sends the whole activity through
- creates an activity within that one method, using the
Problem with python repo: this line in the send_activity method hard-codes the activity.input_hint to always be set to 'acceptingInput'.
Expected behavior
Python's TurnContext class should allow setting activity.input_hint and not overwrite to 'acceptingInput' no matter the case
[bug]
Metadata
Metadata
Assignees
Labels
P1Painful if we don't fix, won't block releasingPainful if we don't fix, won't block releasing