Skip to content

TurnContext hardcodes Activity.input_hint to always be 'acceptingInput' #197

@Zerryth

Description

@Zerryth

Version

preview 2

Describe the bug

In botbuilder-dotnet and botbuilder-js repos, the TurnContext class allows the user to set the value of activity.input_hint.

  • dotnet: has 2 SendActivityAsync() methods:

    1. if the prompt is just a text, then to allow inputHint parameter & create an activity to send with the text and inputHint
    2. if the prompt is an Activity, then to just send the activity through--if change in Activity.InputHint is desired, then it must be changed on the activity itself, before passing into SendActivityAsync() method
  • js: has 1 .sendActivity() method whose first parameter can be either string or Activity and as a separate parameter accepts inputHint

    • creates an activity within that one method, using the inputHint arg passed in or if it's an Activity, sends the whole activity through

Problem with python repo: this line in the send_activity method hard-codes the activity.input_hint to always be set to 'acceptingInput'.

Expected behavior

Python's TurnContext class should allow setting activity.input_hint and not overwrite to 'acceptingInput' no matter the case

[bug]

Metadata

Metadata

Assignees

Labels

P1Painful if we don't fix, won't block releasing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions