Fix the type of copyWithin
#53340
Fix the type of copyWithin
#53340
Conversation
typescript-bot
added
the
For Uncommitted Bug
Only the first parameter of `copyWithin` is required, contrary to the type in the typedef. This commit fixes that type to allow correct usage of the `copyWithin` function. See [the usage of copy within](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/copyWithin).
ericbf
force-pushed
the
fix-copyWithin-type
branch
from
35bdb24 to
f581696
Compare
typescript-bot
removed
the
For Uncommitted Bug
|
The type change looks fine to me (making it optional), although I'm not sure about all of that extra JSDoc outlining the edge cases. |
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
The linked bug is to change the signature, not the JS Doc, so please just change the signature. Please file a separate issue if you want to change the doc comments too.
You got it. No change at all? Or should it at least mention start's being omitted? I can update again if it’s more desirable to have no change at all in the JS Doc (despite the signature changing). But it makes sense that the JS Doc should at least mention the updated signature. |
I got a little ambitious 😅. Apologies! |
|
Thanks! |
4 participants
Only the first parameter of
copyWithinis required, contrary to the type in the typedef. This commit fixes that type to allow correct usage of thecopyWithinfunction. See the usage ofcopyWithin.Fixes #53334