Skip to content

Fix the type of copyWithin #53340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Fix the type of copyWithin #53340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f581696
Fix the type of `copyWithin`
ericbf Mar 18, 2023
8a67910
Remove all those JSDoc changes.
ericbf Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/es2015.core.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ interface Array<T> {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;
}

interface ArrayConstructor {
Expand Down
8 changes: 4 additions & 4 deletions src/lib/es2020.bigint.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,10 @@ interface BigInt64Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/** Yields index, value pairs for every entry in the array. */
entries(): IterableIterator<[number, bigint]>;
Expand Down Expand Up @@ -419,10 +419,10 @@ interface BigUint64Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/** Yields index, value pairs for every entry in the array. */
entries(): IterableIterator<[number, bigint]>;
Expand Down
36 changes: 18 additions & 18 deletions src/lib/es5.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1849,10 +1849,10 @@ interface Int8Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/**
* Determines whether all the members of an array satisfy the specified test.
Expand Down Expand Up @@ -2131,10 +2131,10 @@ interface Uint8Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/**
* Determines whether all the members of an array satisfy the specified test.
Expand Down Expand Up @@ -2413,10 +2413,10 @@ interface Uint8ClampedArray {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/**
* Determines whether all the members of an array satisfy the specified test.
Expand Down Expand Up @@ -2694,10 +2694,10 @@ interface Int16Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/**
* Determines whether all the members of an array satisfy the specified test.
Expand Down Expand Up @@ -2976,10 +2976,10 @@ interface Uint16Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/**
* Determines whether all the members of an array satisfy the specified test.
Expand Down Expand Up @@ -3258,10 +3258,10 @@ interface Int32Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/**
* Determines whether all the members of an array satisfy the specified test.
Expand Down Expand Up @@ -3540,10 +3540,10 @@ interface Uint32Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/**
* Determines whether all the members of an array satisfy the specified test.
Expand Down Expand Up @@ -3821,10 +3821,10 @@ interface Float32Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/**
* Determines whether all the members of an array satisfy the specified test.
Expand Down Expand Up @@ -4104,10 +4104,10 @@ interface Float64Array {
* @param target If target is negative, it is treated as length+target where length is the
* length of the array.
* @param start If start is negative, it is treated as length+start. If end is negative, it
* is treated as length+end.
* is treated as length+end. If start is omitted, `0` is used.
* @param end If not specified, length of the this object is used as its default value.
*/
copyWithin(target: number, start: number, end?: number): this;
copyWithin(target: number, start?: number, end?: number): this;

/**
* Determines whether all the members of an array satisfy the specified test.
Expand Down
Loading