Use IIFE to capture variable for transformed dynamic import #51581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
Contributor
Contributor
Author
|
Closed in favor of #51562 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #49663 we fixed one issue related to closures and dynamic import, but introduced another. This changes the emit to use an IIFE to ensure the value of the variable is captured properly. We could potentially drop back to the
_a = x, Promise.resolve().then(...)emit if we're not in any loop, but that would require tracking iteration statements as we descend, and dynamic import isn't likely to be used in a fast path that cares about the overhead of an IIFE.Fixes #51554.