Avoid emitting temp variable in downleveled import() #51562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Josh-Cena
force-pushed
the
fix-dynamic-import-again
branch
from
8dc9006 to
a667884
Compare
Josh-Cena
commented
Nov 16, 2022
| const path = `${directory}\\moduleFile`; | ||
| _a = yield path, Promise.resolve().then(() => require(_a)); | ||
| Promise.resolve(`${yield path}`).then(s => require(s)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The previous behavior here looked exactly like the bug because they would all import the same thing...
rbuckton
approved these changes
Nov 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51554