Don't uninstall typescript before npm ci in GHA #50062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
weswigham
approved these changes
Jul 27, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been carried through from #9316, where it was needed to make Travis' caching faster. But, this doesn't have any meaning on GitHub Actions; caching is something you have to opt into, and even if we did opt into it (we don't! I'll send another PR), it wouldn't actually do anything.
Remove this as this interferes with
npm ci, becausenpm uninstallwill modifypackage-lock.json. This is important to keep our Node 14 builder working properly if we were to change our npm version / lockfile verison.See also #49726, #50061