Skip to content

Conversation

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Jul 26, 2022

This dependency triggers a CG warning (previously failed DT enough we had to delete packages, not sure why TS is also not failing somewhere).

Now that we use npm 8, we can use overrides to downgrade it.

@jakebailey
Copy link
Member Author

jakebailey commented Jul 27, 2022

Node 14 actually works fine once the uninstall is removed, which makes sense. Sent #50062.

@jakebailey jakebailey marked this pull request as ready for review August 3, 2022 16:49
@jakebailey
Copy link
Member Author

jakebailey commented Aug 3, 2022

Just to illustrate that this works on Node 14 / npm 6 when using npm ci, compare:

So, that's good.

@jakebailey jakebailey merged commit a3a5e00 into microsoft:main Aug 3, 2022
@jakebailey jakebailey deleted the npm-overrides branch August 3, 2022 17:47
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants