Skip to content

Protect against a language service host mutating its underlying source for getScriptFileNames #49813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Protect against a language service host mutating its underlying source for getScriptFileNames #49813

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e57f00
Protect against a language service host mutating its underlying sourc…
andrewbranch Jul 6, 2022
e84f0f9
Add comment
andrewbranch Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/services/services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,10 @@ namespace ts {
lastTypesRootVersion = typeRootsVersion;
}

const rootFileNames = host.getScriptFileNames();
// This array is retained by the program and will be used to determine if the program is up to date,
// so we need to make a copy in case the host mutates the underlying array - otherwise it would look
// like every program always has the host's current list of root files.
const rootFileNames = host.getScriptFileNames().slice();

// Get a fresh cache of the host information
const newSettings = host.getCompilationSettings() || getDefaultCompilerOptions();
Expand Down