Protect against a language service host mutating its underlying source for getScriptFileNames
#49813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for `getScriptFileNames`
typescript-bot
added
Author: Team
For Uncommitted Bug
amcasey
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a loose thread from #48980: constructing a
HostCacheused to effectively make a copy of this array; now that we no longer need a separate data structure, it seems like we can just use the array, but in fact we still need to make a copy in case the host wants to mutate what it passes as its state changes (I’m reading that mutation by the host is valid by the fact that it’s astring[], not areadonly string[]—plus, it’s a lot to ask of every language service consumer to think about this).This fixes the twoslash/bisect runner, which has been telling us that all TypeScript code has started crashing at #48980 😄