Improve WebAssembly.Instance constructor #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on microsoft#755 and microsoft#766, improves imports param in constructor instead.
Contributor
Author
|
@orta I guess I was wrong about "the last one" after all :) |
Contributor
|
👍 Cool, thanks! |
Contributor
Author
|
@orta Thanks for merging! I made a PR to TypeScript to bump typings, as you suggested before, but looks like bot is configured to auto-close such PRs immediately: microsoft/TypeScript#33753 Can you please help with reopening and getting them merged? |
sandersn
pushed a commit
to microsoft/TypeScript
that referenced
this pull request
Oct 14, 2019
This bumps generated bindings to include microsoft/TypeScript-DOM-lib-generator#767. Note that other related APIs were already updated in microsoft/TypeScript-DOM-lib-generator#755 and microsoft/TypeScript-DOM-lib-generator#756 and included in current TypeScript beta. Unfortunately, this one slipped under the radar, but it would be really great to include these changes in beta too for consistency between different WebAssembly methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #755 and #766, improves imports param in constructor instead.