Add missing cpx dependency
#766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's used by baseline-accept script, but not referenced in dependencies and so fails to run on fresh checkout.
RReverser
added a commit
to RReverser/TSJS-lib-generator
that referenced
this pull request
Sep 30, 2019
Based on microsoft#755 and microsoft#766, improves imports param in constructor instead.
|
|
|
@saschanaz I don't think it really matters here tbh, but either is fine by me. |
|
It kinda matters because #742 was to fix the security warning... (It feels bad to see warnings after |
|
As I said, fine by me either way :) Updated PR. |
This was referenced Oct 20, 2019
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's used by baseline-accept script, but not referenced in dependencies and so fails to run on fresh checkout.