This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix #511 for fixed point amplitude amplification #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
reviewed
Feb 16, 2022
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
LGTM. Marking as comment only since it's still in draft. Only suggestion might be to add a new unit test to cover this case. Thanks!
Member
Author
I agree, there are still some more issues with the current implementation, so I haven't pushed my test case yet such that the pipeline does not break. |
cgranade
approved these changes
Mar 8, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #511