You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Expected origin of the bug
At line 59: let beta = Cosh((1.0 / nQueriesDouble) * ArcCosh(Sqrt(successMin)));
ArcCosh is called on a value less than 1.
Expected fix
From https://arxiv.org/pdf/1409.3305.pdf: gamma^{-1} = T_{1/L} (1/delta).
I think that the Cosh and ArcCosh should be Cos and ArcCos instead.
(Other fixes may be needed too).
Additional context
Thanks for the great Amplitude Amplification library!