-
Notifications
You must be signed in to change notification settings - Fork 147
Replace RadIO with TorchIO for patch-based inference #666
Conversation
2aaf96b to
201ed00
Compare
|
I "fixed" some mypy errors by explicitly ignoring them. I'm not sure this is the best solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking GREAT! Lots of ugly code replaced by uncle tio ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#665 Lets address this one before merging and run manual regression test on prostate and H&N
Comparison RadIO vs TorchIOI suspect the tiny differences might be due to implementation details. For example, if an image needs to be 3 voxels larger along a specific dimensions, we could add 2 voxels at the beginning and 1 at the end, or vice versa. QuantitativeRadIO
TorchIO
Qualitative |
|
I can run H&N too, but I suspect results will be very similar again. |

Write a detailed description of your PR here.
Please follow the guidelines for PRs contained here. Checklist:
Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.