Skip to content

Conversation

@Eskibear
Copy link
Member

No description provided.

@Eskibear Eskibear marked this pull request as ready for review March 6, 2024 07:39
@mrm9084
Copy link
Contributor

mrm9084 commented Mar 7, 2024

@Eskibear is expected that files don't end in a new line? Have you setup a formatter for this yet?

@Eskibear
Copy link
Member Author

Eskibear commented Mar 8, 2024

@Eskibear is expected that files don't end in a new line? Have you setup a formatter for this yet?

Good catch. I'll add eol-last rule in eslint config file.

@Eskibear
Copy link
Member Author

@zhiyuanliang-ms @mrm9084
All above comments are resolved. Do you have any further comment, or we get this init PR merged?

@Eskibear Eskibear merged commit 00d613c into main Mar 27, 2024
@Eskibear Eskibear deleted the yanzh/init branch March 27, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants