provide separate built-in providers for object and map

Author: Eskibear

src/featureProvider.ts

@@ -5,22 +5,33 @@ export interface IFeatureProvider {
     getFeatureFlags(): Promise<FeatureDefinition[]>;
 }
 
-export class ConfigurationFeatureProvider implements IFeatureProvider {
-    #configuration: IGettable | Record<string, unknown>;
+/**
+ * TBD
+ */
+export class ConfigurationMapFeatureProvider implements IFeatureProvider {
+    #configuration: IGettable;
 
-    constructor(configuration: Record<string, unknown> | IGettable) {
-        if (typeof configuration !== "object") {
-            throw new Error("Configuration must be an object.");
-        }
+    constructor(configuration: IGettable) {
         this.#configuration = configuration;
     }
 
     async getFeatureFlags(): Promise<FeatureDefinition[]> {
-        if (isGettable(this.#configuration)) {
-            const featureConfig = this.#configuration.get<FeatureConfiguration>(FEATURE_MANAGEMENT_KEY);
-            return featureConfig?.[FEATURE_FLAGS_KEY] ?? [];
-        } else {
-            return this.#configuration[FEATURE_MANAGEMENT_KEY]?.[FEATURE_FLAGS_KEY] ?? [];
-        }
+        const featureConfig = this.#configuration.get<FeatureConfiguration>(FEATURE_MANAGEMENT_KEY);
+        return featureConfig?.[FEATURE_FLAGS_KEY] ?? [];
     }
 }
+
+/**
+ * TBD
+ */
+export class ConfigurationObjectFeatureProvider implements IFeatureProvider {
+    #configuration: Record<string, unknown>;
+
+    constructor(configuration: Record<string, unknown> ) {
+        this.#configuration = configuration;
+    }
+
+    async getFeatureFlags(): Promise<FeatureDefinition[]> {
+        return this.#configuration[FEATURE_MANAGEMENT_KEY]?.[FEATURE_FLAGS_KEY] ?? [];
+    }
+}

src/index.ts

@@ -2,4 +2,4 @@
 // Licensed under the MIT license.
 
 export { FeatureManager } from "./featureManager";
-export { ConfigurationFeatureProvider, IFeatureProvider } from "./featureProvider";
+export { ConfigurationMapFeatureProvider, ConfigurationObjectFeatureProvider, IFeatureProvider } from "./featureProvider";

test/featureManager.test.ts

@@ -6,7 +6,7 @@ import * as chaiAsPromised from "chai-as-promised";
 chai.use(chaiAsPromised);
 const expect = chai.expect;
 
-import { FeatureManager, ConfigurationFeatureProvider } from "./exportedApi";
+import { FeatureManager, ConfigurationMapFeatureProvider, ConfigurationObjectFeatureProvider } from "./exportedApi";
 
 describe("feature manager", () => {
     it("should load from json string", () => {
@@ -18,7 +18,7 @@ describe("feature manager", () => {
             }
         };
 
-        const provider = new ConfigurationFeatureProvider(jsonObject);
+        const provider = new ConfigurationObjectFeatureProvider(jsonObject);
         const featureManager = new FeatureManager(provider);
         return expect(featureManager.isEnabled("Alpha")).eventually.eq(true);
     });
@@ -31,7 +31,7 @@ describe("feature manager", () => {
             ],
         });
 
-        const provider = new ConfigurationFeatureProvider(dataSource);
+        const provider = new ConfigurationMapFeatureProvider(dataSource);
         const featureManager = new FeatureManager(provider);
         return expect(featureManager.isEnabled("Alpha")).eventually.eq(true);
     });
@@ -44,7 +44,7 @@ describe("feature manager", () => {
             ],
         });
 
-        const provider = new ConfigurationFeatureProvider(dataSource);
+        const provider = new ConfigurationMapFeatureProvider(dataSource);
         const featureManager = new FeatureManager(provider);
         dataSource.set("FeatureManagement", {
             FeatureFlags: [
@@ -64,7 +64,7 @@ describe("feature manager", () => {
             ],
         });
 
-        const provider = new ConfigurationFeatureProvider(dataSource);
+        const provider = new ConfigurationMapFeatureProvider(dataSource);
         const featureManager = new FeatureManager(provider);
         return Promise.all([
             expect(featureManager.isEnabled("Alpha")).eventually.eq(true),