-
Notifications
You must be signed in to change notification settings - Fork 119
Fix build warning #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build warning #462
Conversation
|
/AzurePipeline run |
What makes the nullable incorrect here? |
@rossgrambo I am trying to fix these build warnings: Microsoft.FeatureManagement -> C:\Users\zhiyuanliang\OneDrive - Microsoft\Desktop\Dev\FM\src\Microsoft.FeatureManagement\bin\Debug\netstandard2.1\Microsoft.FeatureManagement.dll There is inconsistent usage of nullable type. There are two options to fix these build warnings:
I prefer the second option. |
|
/AzurePipeline run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I see. We're setting nullable true but not using the nullable ? everywhere where applicable.
|
Then, too many changes are needed, especially for FeatureFlagDemo project. I don't think it's worthy because our feature management projects don't set property to true. Example projects just follow them. |
|
@rossgrambo |
Why this PR?
Fix xUnit1031 warning.
Remove nullable property in example projects.
Visible changes
Update testcases to use async&await.
Update property.