Fix solution issues #305
Merged
Fix solution issues #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jimmyca15
commented
Nov 7, 2023
jimmyca15
commented
- missing project inclusion in solution file
- Project declared nullable support but wasn't written with it in mind
- pack.ps1 script didn't reference newest project.
* missing project inclusion in solution file * Project declared nullable support but wasn't written with it in mind * pack.ps1 script didn't reference newest project.
Member
|
Should we remove the nullable declaration in RazorPages example project? |
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> |
Member
There was a problem hiding this comment.
Is there any reason that we keep the enables in the RazorPages example?
Member
Author
There was a problem hiding this comment.
Because that project was made with nullable in mind. It uses it correctly. The other projects don't use nullable in the code, and it seems it was added into csproj after the fact causing compiler warnings.
Member
Author
|
@zhiyuanliang-ms any further concerns on this PR? |
zhiyuanliang-ms
approved these changes
Nov 15, 2023
Member
|
@jimmyca15 I have no further concerns about this PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.