Skip to content

Correctly output more than two levels in nested pass-through (_elseNested). #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2021
Merged

Correctly output more than two levels in nested pass-through (_elseNested). #392

merged 2 commits into from
Sep 23, 2021

Conversation

@blackwinter
Copy link
Member

@blackwinter blackwinter commented Sep 14, 2021

Keep track of nested entities and open/close them in the appropriate order.

If anyone has any more edge cases we should test for, please let me know.

Fixes #378.

Related to #107, #338.

@blackwinter
Correctly output more than two levels in nested pass-through (`_elseN…
4b8c2d7 
…ested`).

Keep track of nested entities and open/close them in the appropriate order.

Fixes #378.

Related to #107, #338.
@blackwinter blackwinter requested a review from dr0i September 14, 2021 17:43
@blackwinter blackwinter linked an issue Sep 15, 2021 that may be closed by this pull request
_elseNested loses array-key in JSON #374
Closed
@blackwinter blackwinter mentioned this pull request Sep 15, 2021
Closed
@blackwinter
Copy link
Member Author

blackwinter commented Sep 15, 2021

Also seems to fix #374.

@TobiasNx: Can you verify?

@TobiasNx
Copy link
Contributor

TobiasNx commented Sep 20, 2021

Also seems to fix #374.

@TobiasNx: Can you verify?

#374 (comment)

Works fine now! +1

@blackwinter
Copy link
Member Author

blackwinter commented Sep 20, 2021

Thanks for checking!

@dr0i
Copy link
Member

dr0i commented Sep 23, 2021

Great!

@dr0i dr0i assigned blackwinter and unassigned dr0i Sep 23, 2021
@blackwinter
Copy link
Member Author

blackwinter commented Sep 23, 2021

Thank you :)

@blackwinter blackwinter merged commit 8af6c69 into master Sep 23, 2021
@blackwinter blackwinter deleted the 378-fixElseNestedWithMoreThanTwoLevels branch September 23, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dr0i dr0i dr0i approved these changes

Assignees

@blackwinter blackwinter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_elseNested only outputs two hierachy levels _elseNested loses array-key in JSON

4 participants

@blackwinter @TobiasNx @dr0i