_elseNested: Entity with more than one subfield results in multiple entities

[dr0i]

Reported by @hagbeck:

I've observed another effect.

<marc:datafield tag="856" ind1="4" ind2="0">
   <marc:subfield code="u">http://www.video2brain.com/</mx:subfield>
   <marc:subfield code="x">Agentur</mx:subfield>
</marc:datafield>

results in multiple entities like

<marc:datafield tag="856" ind1="4" ind2="0">
        <marc:subfield code="u">http://www.video2brain.com/</marc:subfield>
</marc:datafield>
<marc:datafield tag="856" ind1="4" ind2="0">
        <marc:subfield code="x">Agentur</marc:subfield>
</marc:datafield>

using the '_elseNested' morph.

Originates from #107.

[blackwinter]

Fortunately, we have a test for this. Unfortunately, the test is insufficient. All (?) tests should verifyNoMoreInteractions:

diff --git metamorph/src/test/java/org/metafacture/metamorph/TestMetamorphBasics.java metamorph/src/test/java/org/metafacture/metamorph/TestMetamorphBasics.java
index a564bed8..29fc828c 100644
--- metamorph/src/test/java/org/metafacture/metamorph/TestMetamorphBasics.java
+++ metamorph/src/test/java/org/metafacture/metamorph/TestMetamorphBasics.java
@@ -19,6 +19,7 @@
 import static org.mockito.Mockito.inOrder;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoMoreInteractions;
 
 import org.junit.Rule;
 import org.junit.Test;
@@ -156,6 +157,8 @@ public void shouldHandleUnmatchedLiteralsAndEntitiesInElseNestedSource() {
         ordered.verify(receiver).literal("Hawaii", "Aloha");
         ordered.verify(receiver).endEntity();
         ordered.verify(receiver).endRecord();
+        ordered.verifyNoMoreInteractions();
+        verifyNoMoreInteractions(receiver);
     }
 
     @Test

> Task :metamorph:test

org.metafacture.metamorph.TestMetamorphBasics > shouldHandleUnmatchedLiteralsAndEntitiesInElseNestedSource FAILED
    org.mockito.exceptions.verification.NoInteractionsWanted at TestMetamorphBasics.java:161

168 tests completed, 1 failed, 1 skipped

[...]

BUILD FAILED in 5s
126 actionable tasks: 2 executed, 124 up-to-date

diff --git metamorph/src/test/java/org/metafacture/metamorph/TestMetamorphBasics.java metamorph/src/test/java/org/metafacture/metamorph/TestMetamorphBasics.java
index 29fc828c..1cf6700d 100644
--- metamorph/src/test/java/org/metafacture/metamorph/TestMetamorphBasics.java
+++ metamorph/src/test/java/org/metafacture/metamorph/TestMetamorphBasics.java
@@ -151,6 +151,8 @@ public void shouldHandleUnmatchedLiteralsAndEntitiesInElseNestedSource() {
         ordered.verify(receiver).literal("Shikotan", "Aekap");
         ordered.verify(receiver).startEntity("Germany");
         ordered.verify(receiver).literal("Langeoog", "Moin");
+        ordered.verify(receiver).endEntity();
+        ordered.verify(receiver).startEntity("Germany");
         ordered.verify(receiver).literal("Baltrum", "Moin Moin");
         ordered.verify(receiver).endEntity();
         ordered.verify(receiver).startEntity("USA");

BUILD SUCCESSFUL in 5s
131 actionable tasks: 2 executed, 129 up-to-date