Skip to content

Conversation

IAmSurajBobade
Copy link
Contributor

@IAmSurajBobade IAmSurajBobade commented Sep 4, 2025

Description

Fixes #541 (if applicable)

Before:

func main() {
    // Create MCP Server
    s := server.NewMCPServer("Custom StreamableHTTP Server", "1.0.0")
    
    // Create HTTP server with custom routes
    mux := http.NewServeMux()
    
    // Add MCP endpoints
    server.AddMCPRoutes(mux, s, "/mcp")
}

After:

func main() {
    s := server.NewMCPServer("Custom StreamableHTTP Server", "1.0.0")
    
    // Create HTTP server with custom routes
    mux := http.NewServeMux()
    
    // Add MCP endpoints
    mux.Handle("/mcp", server.NewStreamableHTTPServer(s))
}

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • MCP spec compatibility implementation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Tests only (no functional changes)
  • Other (please describe):

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the documentation accordingly

MCP Spec Compliance

  • This PR implements a feature defined in the MCP specification
  • Link to relevant spec section: Link text
  • Implementation follows the specification exactly

Additional Information

Copy link
Contributor

coderabbitai bot commented Sep 4, 2025

Walkthrough

Documentation updates in the HTTP transport guide to use a StreamableHTTPServer mounted at /mcp instead of AddMCPRoutes, along with a minor formatting tweak in the “Next Steps” section.

Changes

Cohort / File(s) Summary of changes
Docs: HTTP transport
www/docs/pages/transports/http.mdx
Update example to mount server.NewStreamableHTTPServer(s) at /mcp instead of calling server.AddMCPRoutes(...); minor formatting change in “Next Steps”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3d1bfca and 8ca8323.

📒 Files selected for processing (1)
  • www/docs/pages/transports/http.mdx (2 hunks)
🔇 Additional comments (2)
www/docs/pages/transports/http.mdx (2)

696-696: LGTM: link text tweak

The “Server Basics” bullet formatting looks good.


370-370: Fix ServeMux pattern to match /mcp subpaths and optionally redirect /mcp

-    mux.Handle("/mcp", server.NewStreamableHTTPServer(s))
+    mux.Handle("/mcp/", server.NewStreamableHTTPServer(s))
+    // (Optional) ensure /mcp redirects to /mcp/
+    mux.Handle("/mcp", http.RedirectHandler("/mcp/", http.StatusMovedPermanently))
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@IAmSurajBobade IAmSurajBobade changed the title docs(server): Correct Custom Endpoint example https://mcp-go.dev/transports/http#custom-endpoints docs(server): Correct custom endpoint example for streamable HTTP transport Sep 4, 2025
@ezynda3 ezynda3 merged commit 47e9419 into mark3labs:main Sep 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Custom endpoints documentation not up to date
2 participants