Skip to content

Small fix for when selectbox destroyed #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2015
Merged

Small fix for when selectbox destroyed #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 55 additions & 41 deletions jquery.selectBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
*
* https://github.com/marcj/jquery-selectBox
*/


;(function ($) {

/**
Expand Down Expand Up @@ -984,44 +986,7 @@
}
};

/**
* Sets the option elements.
*
* @param {String|Object} options
*/
SelectBox.prototype.setOptions = function (options) {
var select = $(this.selectElement)
, control = select.data('selectBox-control');

switch (typeof(options)) {
case 'string':
select.html(options);
break;
case 'object':
select.html('');
for (var i in options) {
if (options[i] === null) {
continue;
}
if (typeof(options[i]) === 'object') {
var optgroup = $('<optgroup label="' + i + '" />');
for (var j in options[i]) {
optgroup.append('<option value="' + j + '">' + options[i][j] + '</option>');
}
select.append(optgroup);
} else {
var option = $('<option value="' + i + '">' + options[i] + '</option>');
select.append(option);
}
}
break;
}

if (control) {
// Refresh the control
this.refresh();
}
};

/**
* Disables the selection.
Expand Down Expand Up @@ -1059,7 +1024,52 @@
* Extends the jQuery.fn object.
*/
$.extend($.fn, {
selectBox: function (method, options) {

/**
* Sets the option elements.
*
* @param {String|Object} options
*/
setOptions : function (options) {
var select = $(this)
, control = select.data('selectBox-control');


switch (typeof(options)) {
case 'string':
select.html(options);
break;
case 'object':
select.html('');
for (var i in options) {
if (options[i] === null) {
continue;
}
if (typeof(options[i]) === 'object') {
var optgroup = $('<optgroup label="' + i + '" />');
for (var j in options[i]) {
optgroup.append('<option value="' + j + '">' + options[i][j] + '</option>');
}
select.append(optgroup);
} else {
var option = $('<option value="' + i + '">' + options[i] + '</option>');
select.append(option);
}
}
break;
}

if (control) {
// Refresh the control
$(this).selectBox('refresh');
// Remove old options

}
},



selectBox: function (method, options) {
var selectBox;

switch (method) {
Expand All @@ -1075,14 +1085,18 @@
break;
case 'options':
// Getter

if (undefined === options) {
return $(this).data('selectBox-control').data('selectBox-options');
}

// Setter
$(this).each(function () {
if (selectBox = $(this).data('selectBox')) {
selectBox.setOptions(options);
}

// if (selectBox = $(this).data('selectBox')) {
$(this).setOptions(options);
// }

});
break;
case 'value':
Expand Down