Skip to content

Conversation

@bogdanRada
Copy link
Contributor

This is a fix for this case:

-- If a selectbox is destroyed but in code you still use this code
$('#element').selectBox('options', data) the select won't get changed with the new options

There might be better ways of dealing with this, but this fixed the issue for me.
I hope you will find it useful

@marcj
Copy link
Owner

marcj commented Mar 18, 2014

Mh, I'm not sure about that.

@bogdanRada
Copy link
Contributor Author

here is a jsfiddle for this: http://jsfiddle.net/f4dm8/5/.
My fix was for this case, that even if you destroy the selectbox, the new options should still appear in the dropdown.

@bogdanRada
Copy link
Contributor Author

is there any chance of getting this merged? that would really be awesome :)

@bogdanRada
Copy link
Contributor Author

@marcj , can you please take a look at this? would be really great if this could be merged . You can check that this issue is still happening by checking the JsFiddle i prepared for this. Please let me know your thoughts on this.

marcj added a commit that referenced this pull request Jun 27, 2015
Small fix for when selectbox destroyed
@marcj marcj merged commit e103503 into marcj:master Jun 27, 2015
@marcj
Copy link
Owner

marcj commented Jun 27, 2015

Thanks @bogdanRada!

@bogdanRada
Copy link
Contributor Author

thank you also :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants