Skip to content

[Access Virus] Analog input knobs for Virus A & B #14461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
+452 −5
Merged

[Access Virus] Analog input knobs for Virus A & B #14461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/devices/cpu/mcs51/sab80c535.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,34 @@ u8 sab80c535_device::p5_r()
return m_p5 & m_port_in_cb[5]();
}

void sab80c535_device::adcon_w(u8 data)
{
m_adcon = data;
}

u8 sab80c535_device::adcon_r()
{
return m_adcon;
}

u8 sab80c535_device::addat_r()
{
return m_an_func[m_adcon & 7]() * 2;
}


void sab80c535_device::sfr_map(address_map &map)
{
i8052_device::sfr_map(map);
map(0xd8, 0xd8).rw(FUNC(sab80c535_device::adcon_r), FUNC(sab80c535_device::adcon_w));
map(0xd9, 0xd9).r(FUNC(sab80c535_device::addat_r));
map(0xe8, 0xe8).rw(FUNC(sab80c535_device::p4_r), FUNC(sab80c535_device::p4_w));
map(0xf8, 0xf8).rw(FUNC(sab80c535_device::p5_r), FUNC(sab80c535_device::p5_w));
}

sab80c535_device::sab80c535_device(const machine_config &mconfig, const char *tag, device_t *owner, u32 clock)
: i8052_device(mconfig, SAB80C535, tag, owner, clock, 0)
, m_an_func(*this, 0)
{
}

Expand All @@ -96,13 +114,15 @@ void sab80c535_device::device_start()
i8052_device::device_start();
save_item(NAME(m_p4));
save_item(NAME(m_p5));
save_item(NAME(m_adcon));
}

void sab80c535_device::device_reset()
{
i8052_device::device_reset();
m_p4 = 0xff;
m_p5 = 0xff;
m_adcon = 0x00;
}

std::unique_ptr<util::disasm_interface> sab80c535_device::create_disassembler()
Expand Down
18 changes: 17 additions & 1 deletion src/devices/cpu/mcs51/sab80c535.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,36 @@ class sab80c535_device : public i8052_device
// construction/destruction
sab80c535_device(const machine_config &mconfig, const char *tag, device_t *owner, u32 clock);

auto an0_func() { return m_an_func[0].bind(); }
auto an1_func() { return m_an_func[1].bind(); }
auto an2_func() { return m_an_func[2].bind(); }
auto an3_func() { return m_an_func[3].bind(); }
auto an4_func() { return m_an_func[4].bind(); }
auto an5_func() { return m_an_func[5].bind(); }
auto an6_func() { return m_an_func[6].bind(); }
auto an7_func() { return m_an_func[7].bind(); }

protected:
virtual void device_start() override ATTR_COLD;
virtual void device_reset() override ATTR_COLD;

virtual std::unique_ptr<util::disasm_interface> create_disassembler() override;
virtual void sfr_map(address_map &map) override ATTR_COLD;

devcb_read8::array<8> m_an_func;

private:
u8 m_p4, m_p5;
u8 m_p4;
u8 m_p5;
u8 m_adcon;

void p4_w(u8 data);
u8 p4_r();
void p5_w(u8 data);
u8 p5_r();
void adcon_w(u8 data);
u8 adcon_r();
u8 addat_r();
};

DECLARE_DEVICE_TYPE(SAB80C535, sab80c535_device)
Expand Down
135 changes: 134 additions & 1 deletion src/mame/access/acvirus.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ class acvirus_state : public driver_device
m_dsp(*this, "dsp"),
m_rombank(*this, "rombank"),
m_row(*this, "ROW%u", 0U),
m_scan(0)
m_knob(*this, "knob_%u", 0U),
m_scan(0),
m_an_select(0)
{ }

void virusa(machine_config &config) ATTR_COLD;
Expand Down Expand Up @@ -119,13 +121,17 @@ class acvirus_state : public driver_device
u8 p1_r();
u8 p4_r();
void p1_w(u8 data);
void p3_w(u8 data);
void p5_w(u8 data);

u8 p402_r();

void palette_init(palette_device &palette) ATTR_COLD;

required_ioport_array<32> m_knob;

u8 m_scan;
u8 m_an_select;
};


Expand All @@ -135,6 +141,7 @@ void acvirus_state::machine_start()
m_rombank->set_entry(3);

save_item(NAME(m_scan));
save_item(NAME(m_an_select));
}

void acvirus_state::machine_reset()
Expand All @@ -154,6 +161,11 @@ void acvirus_state::p1_w(u8 data)
m_lcdc->rs_w(BIT(data, 7));
}

void acvirus_state::p3_w(u8 data)
{
m_an_select = (data >> 4) & 3;
}

u8 acvirus_state::p4_r()
{
return m_row[m_scan & 3]->read();
Expand Down Expand Up @@ -205,8 +217,17 @@ void acvirus_state::virusa(machine_config &config)
m_maincpu->set_addrmap(AS_DATA, &acvirus_state::data_map);
m_maincpu->port_in_cb<1>().set(FUNC(acvirus_state::p1_r));
m_maincpu->port_out_cb<1>().set(FUNC(acvirus_state::p1_w));
m_maincpu->port_out_cb<3>().set(FUNC(acvirus_state::p3_w));
m_maincpu->port_in_cb<4>().set(FUNC(acvirus_state::p4_r));
m_maincpu->port_out_cb<5>().set(FUNC(acvirus_state::p5_w));
m_maincpu->an0_func().set([this] { return m_knob[4*0 + m_an_select]->read(); });
m_maincpu->an1_func().set([this] { return m_knob[4*1 + m_an_select]->read(); });
m_maincpu->an2_func().set([this] { return m_knob[4*2 + m_an_select]->read(); });
m_maincpu->an3_func().set([this] { return m_knob[4*3 + m_an_select]->read(); });
m_maincpu->an4_func().set([this] { return m_knob[4*4 + m_an_select]->read(); });
m_maincpu->an5_func().set([this] { return m_knob[4*5 + m_an_select]->read(); });
m_maincpu->an6_func().set([this] { return m_knob[4*6 + m_an_select]->read(); });
m_maincpu->an7_func().set([this] { return m_knob[4*7 + m_an_select]->read(); });

screen_device &screen(SCREEN(config, "screen", SCREEN_TYPE_LCD));
screen.set_refresh_hz(60);
Expand Down Expand Up @@ -237,8 +258,17 @@ void acvirus_state::virusb(machine_config &config)
m_maincpu->set_addrmap(AS_DATA, &acvirus_state::data_map);
m_maincpu->port_in_cb<1>().set(FUNC(acvirus_state::p1_r));
m_maincpu->port_out_cb<1>().set(FUNC(acvirus_state::p1_w));
m_maincpu->port_out_cb<3>().set(FUNC(acvirus_state::p3_w));
m_maincpu->port_in_cb<4>().set(FUNC(acvirus_state::p4_r));
m_maincpu->port_out_cb<5>().set(FUNC(acvirus_state::p5_w));
m_maincpu->an0_func().set([this] { return m_knob[4*0 + m_an_select]->read(); });
m_maincpu->an1_func().set([this] { return m_knob[4*1 + m_an_select]->read(); });
m_maincpu->an2_func().set([this] { return m_knob[4*2 + m_an_select]->read(); });
m_maincpu->an3_func().set([this] { return m_knob[4*3 + m_an_select]->read(); });
m_maincpu->an4_func().set([this] { return m_knob[4*4 + m_an_select]->read(); });
m_maincpu->an5_func().set([this] { return m_knob[4*5 + m_an_select]->read(); });
m_maincpu->an6_func().set([this] { return m_knob[4*6 + m_an_select]->read(); });
m_maincpu->an7_func().set([this] { return m_knob[4*7 + m_an_select]->read(); });

screen_device &screen(SCREEN(config, "screen", SCREEN_TYPE_LCD));
screen.set_refresh_hz(60);
Expand Down Expand Up @@ -297,7 +327,108 @@ void acvirus_state::virusc(machine_config &config)
}


INPUT_PORTS_START( virusa_knobs )
PORT_START("knob_0")
PORT_ADJUSTER(64, "Master Volume") PORT_MINMAX(0, 127)

PORT_START("knob_1")
PORT_ADJUSTER(64, "Definable 1") PORT_MINMAX(0, 127)

PORT_START("knob_2")
PORT_ADJUSTER(64, "Definable 2") PORT_MINMAX(0, 127)

PORT_START("knob_3")
PORT_ADJUSTER(64, "LFO 1: Rate") PORT_MINMAX(0, 127)

PORT_START("knob_4")
PORT_ADJUSTER(64, "LFO 2: Rate") PORT_MINMAX(0, 127)

PORT_START("knob_5")
PORT_ADJUSTER(64, "Osc 1: Shape") PORT_MINMAX(0, 127)

PORT_START("knob_6")
PORT_ADJUSTER(64, "Osc 1: Wave/PW") PORT_MINMAX(0, 127)

PORT_START("knob_7")
PORT_ADJUSTER(64, "Osc 2: Shape") PORT_MINMAX(0, 127)

PORT_START("knob_8")
PORT_ADJUSTER(64, "Osc 2: Wave/PW") PORT_MINMAX(0, 127)

PORT_START("knob_9")
PORT_ADJUSTER(64, "Osc 2 Semitone") PORT_MINMAX(0, 127)

PORT_START("knob_10")
PORT_ADJUSTER(64, "Osc 2 Detune") PORT_MINMAX(0, 127)

PORT_START("knob_11")
PORT_ADJUSTER(64, "Osc 2 FM Amount") PORT_MINMAX(0, 127)

PORT_START("knob_12")
PORT_ADJUSTER(64, "Mixer Osc Bal") PORT_MINMAX(0, 127)

PORT_START("knob_13")
PORT_ADJUSTER(64, "Mixer Sub Osc") PORT_MINMAX(0, 127)

PORT_START("knob_14")
PORT_ADJUSTER(64, "Mixer Osc Volume") PORT_MINMAX(0, 127)

PORT_START("knob_15")
PORT_ADJUSTER(64, "Value (Program)") PORT_MINMAX(0, 127)

PORT_START("knob_16")
PORT_ADJUSTER(64, "Cutoff") PORT_MINMAX(0, 127)

PORT_START("knob_17")
PORT_ADJUSTER(64, "Cutoff 2") PORT_MINMAX(0, 127)

PORT_START("knob_18")
PORT_ADJUSTER(64, "Filter Attack") PORT_MINMAX(0, 127)

PORT_START("knob_19")
PORT_ADJUSTER(64, "Amp Attack") PORT_MINMAX(0, 127)

PORT_START("knob_20")
PORT_ADJUSTER(64, "Filter Resonance") PORT_MINMAX(0, 127)

PORT_START("knob_21")
PORT_ADJUSTER(64, "Filter EnvAmount") PORT_MINMAX(0, 127)

PORT_START("knob_22")
PORT_ADJUSTER(64, "Filter Key Follow") PORT_MINMAX(0, 127)

PORT_START("knob_23")
PORT_ADJUSTER(64, "Filter Balance") PORT_MINMAX(0, 127)

PORT_START("knob_24")
PORT_ADJUSTER(64, "Filter Decay") PORT_MINMAX(0, 127)

PORT_START("knob_25")
PORT_ADJUSTER(64, "Filter Sustain") PORT_MINMAX(0, 127)

PORT_START("knob_26")
PORT_ADJUSTER(64, "Filter Time") PORT_MINMAX(0, 127)

PORT_START("knob_27")
PORT_ADJUSTER(64, "Filter Release") PORT_MINMAX(0, 127)

PORT_START("knob_28")
PORT_ADJUSTER(64, "Amp Decay") PORT_MINMAX(0, 127)

PORT_START("knob_29")
PORT_ADJUSTER(64, "Amp Sustain") PORT_MINMAX(0, 127)

PORT_START("knob_30")
PORT_ADJUSTER(64, "Amp Time") PORT_MINMAX(0, 127)

PORT_START("knob_31")
PORT_ADJUSTER(64, "Amp Release") PORT_MINMAX(0, 127)
INPUT_PORTS_END


static INPUT_PORTS_START( virusa )
PORT_INCLUDE( virusa_knobs )

PORT_START("ROW0")
PORT_BIT(0x01, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_1) PORT_NAME("Key Follow")
PORT_BIT(0x02, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_V) PORT_NAME("Multi")
Expand Down Expand Up @@ -340,6 +471,8 @@ INPUT_PORTS_END


static INPUT_PORTS_START( virusb )
PORT_INCLUDE( virusa_knobs )

PORT_START("ROW0")
PORT_BIT(0x01, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_1) PORT_NAME("LFO 1: Edit")
PORT_BIT(0x02, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_V) PORT_NAME("Multi")
Expand Down
Loading
Loading