[Access Virus] Analog input knobs for Virus A & B #14461
Merged
+452
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
On Virus B, this can be tested by holding "W" during boot, which starts the power-on "knobs test". |
m1macrophage
reviewed
Nov 2, 2025
| <element name="transparent"><rect><color red="0.0" green="0.0" blue="0.0" alpha="0.0"/></rect></element> | ||
| <element name="knob_outer"><disk><color red="0.0" green="0.0" blue="0.0" alpha="0.0"/></disk></element> | ||
| <element name="knob_value"> | ||
| <simplecounter maxstate="100" digits="1"><color red="0.8" green="0.8" blue="0.8"/></simplecounter> |
Contributor
There was a problem hiding this comment.
The max value in PORT_MINMAX is set to 127. Should the same be used for maxstate?
Contributor
Author
There was a problem hiding this comment.
I agree, in principle. But testing the proposed change locally I am seeing no difference.
felipesanches
added a commit
to felipesanches/mame
that referenced
this pull request
Nov 5, 2025
Following suggestion by @m1macrophage at mamedev#14461 (review)
felipesanches
added a commit
to felipesanches/mame
that referenced
this pull request
Nov 5, 2025
Following suggestion by @m1macrophage at mamedev#14461 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.