Make Browser configurable with command line option #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the check if the browser binary exists into the block with the default discovery. This makes it possible to configure the Browser in the jsTestDriver.php file with command line arguments. For example: 'Browser' => '/Applications/Firefox.app/Contents/MacOS/firefox -P "selenium"', Without the change the check would fail, since the value is not an existing file name, but rather a file name including command line options.
Contributor
Author
|
Closed, a larger refactoring PR for the run_js_test.php script is coming. |
magento-team
pushed a commit
that referenced
this pull request
Mar 24, 2017
[EngCom] Fix relative template references in individual Magento modules #1895
magento-team
pushed a commit
that referenced
this pull request
Jan 19, 2018
magento-team
pushed a commit
that referenced
this pull request
Jan 19, 2018
hostep
pushed a commit
to hostep/magento2
that referenced
this pull request
Aug 11, 2018
…-engcom/develop-prs-isolated [EngCom] Fix relative template references in individual Magento modules magento#1895 (cherry picked from commit a434162)
magento-engcom-team
added a commit
that referenced
this pull request
Oct 2, 2019
- Merge Pull Request magento/graphql-ce#955 from swnsma/graphql-ce:Add-Shipping-Address-Input-Extension - Merged commits: 1. d42c828 2. 0402368 3. be027d8
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the check if the browser binary exists into the block with the default
discovery. This makes it possible to configure the Browser in the jsTestDriver.php
file with command line arguments.
For example:
Without the change the check would fail, since the value is not an existing
file name, but rather a file name including command line options.