Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Conversation

@swnsma
Copy link
Contributor

@swnsma swnsma commented Sep 22, 2019

Description (*)

Add possibility to extend receiving Shipping Address.
Case:

  • You would like to add extra attribute to the Shipping Address.
  • You can add Extension Attributes to the Quote Address.
  • To pass the field to Shipping Address, you add the field to ShippingAddressInput (you need attribute which can be present in any case: if you pass address input data or if you pass customer_address_id).
  • You need to pass the attribute to the address before it will be saved to the quote.
    The only way to handle this scenario for now - create preference for \Magento\QuoteGraphQl\Model\Cart\SetShippingAddressesOnCartInterface

The described case was faced in magento/inventory#2427

Changes in this PR provide a single class which is responsible for receiving shipping address based on GraphQl input.
This provides extension point to modify the address after it was resolved and before it was saved in Quote.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@swnsma swnsma requested a review from lenaorobei September 22, 2019 13:27
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 22, 2019

CLA assistant check
All committers have signed the CLA.

Move logic related to Shipping Address to the GetShippingAddress service.
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5983 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit be027d8 into magento:2.3-develop Oct 2, 2019
@ghost
Copy link

ghost commented Oct 2, 2019

Hi @swnsma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants