Msi 2382 graph ql support for in store pickup mutation #2427

swnsma · 2019-07-28T07:41:38Z

Description

Extension of Quote Graph Ql endpoint to become able to pass pickup location code.
Issue: #2382

Add simple module declaration.

Add parameter to SetShippingAddress mutation.

Add api tests coverage.

Fix static tests.

swnsma · 2019-07-28T08:26:28Z

Not sure about copy-paste detector.
For me, it looks that it will be easier to maintain, if the code will be the same.

ishakhsuvarov · 2019-07-29T16:01:03Z

@swnsma CPD is something we can ignore if there is a valid reason. Shouldn't be a problem here.

Fix bug with deletion of address pickup locatio .

Add Pickup Location to Quote Shipping Address Graph Ql Schema. Fix adding of Pickup Location Code to Shipping Address.

…e-Pickup-Mutation

ishakhsuvarov · 2019-08-28T19:04:07Z

...de/Magento/InventoryInStorePickup/Test/_files/create_in_store_pickup_quote_on_eu_website.php

 $cartRepository->save($cart);
+
+/** @var \Magento\Quote\Model\QuoteIdMask $quoteIdMask */
+$quoteIdMask = Bootstrap::getObjectManager()->create(QuoteIdMaskFactory::class)->create();


Should we specify in the fixture name that this is a guest quote?

To be honest, I think there need to be done arrangement of fixtures.
I think we can rename it to 'guest' but during API tests coverage, fixtures need to be refactored.

ishakhsuvarov · 2019-08-28T19:05:29Z

...o/InventoryInStorePickup/Test/_files/create_in_store_pickup_quote_on_eu_website_customer.php

+$cartRepository->save($cart);
+
+/** @var \Magento\Quote\Model\QuoteIdMask $quoteIdMask */
+$quoteIdMask = Bootstrap::getObjectManager()->create(QuoteIdMaskFactory::class)->create();


Fixture name states that it's intended for customer, but this seems to be another guest quote.

The point that masked_quote_id is required in any case.
Please see.
\Magento\QuoteGraphQl\Model\Resolver\SetShippingAddressesOnCart::resolve
\Magento\QuoteGraphQl\Model\Cart\GetCartForUser::execute

.../InventoryInStorePickupQuote/Model/Quote/ValidationRule/InStorePickupQuoteValidationRule.php

...Magento/InventoryInStorePickupQuote/Model/ResourceModel/DeleteQuoteAddressPickupLocation.php

app/code/Magento/InventoryInStorePickupQuote/Plugin/Quote/PassPickupLocationToOrder.php

ishakhsuvarov · 2019-08-28T19:15:38Z

app/code/Magento/InventoryInStorePickupQuoteGraphQl/Model/Cart/SetShippingAddressesOnCart.php

+/**
+ * Set shipping address to the cart. Proceed with passed Pickup Location code.
+ */
+class SetShippingAddressesOnCart implements SetShippingAddressesOnCartInterface


Suggested change

class SetShippingAddressesOnCart implements SetShippingAddressesOnCartInterface

class SetShippingAddressesToCart implements SetShippingAddressesToCartInterface

The original interface has name 'SetShippingAddressesOnCartInterface'.
I think that this is better to keep them similar.

…2382-GraphQl-support-for-In-Store-Pickup-Mutation Conflicts: composer.lock

ishakhsuvarov · 2019-08-28T19:22:19Z

app/code/Magento/InventoryInStorePickupQuoteGraphQl/Model/Cart/SetShippingAddressesOnCart.php

+     * @throws GraphQlInputException
+     * @throws GraphQlNoSuchEntityException
+     */
+    private function getShippingAddress(array $shippingAddressInput, ContextInterface $context): Address


Why isn't it possible just to implement a plugin for the class where this logic originally came from?

Do you mean around plugin without calling the proceed?

...gento/InventoryInStorePickupQuoteGraphQl/Test/Api/Customer/PickupLocationForShippingTest.php

.../Magento/InventoryInStorePickupQuoteGraphQl/Test/Api/Guest/PickupLocationForShippingTest.php

app/code/Magento/InventoryInStorePickupQuoteGraphQl/etc/schema.graphqls

ishakhsuvarov

Please take a look at the review comments

Apply code review changes.

…of github.com:magento-engcom/msi into MSI-2382-GraphQl-support-for-In-Store-Pickup-Mutation

swnsma · 2019-08-29T08:00:54Z

Hi guys, @ishakhsuvarov @lenaorobei,

Thank you for your review.
I have reacted on code review notices.

…2382-GraphQl-support-for-In-Store-Pickup-Mutation

…e-Pickup-Mutation

Fix Pickup Location missed for created order.

…of github.com:magento-engcom/msi into MSI-2382-GraphQl-support-for-In-Store-Pickup-Mutation

lenaorobei · 2019-09-11T18:48:05Z

No other comments from my side. Please make sure that schema is submitted and approved here https://github.com/magento/architecture/tree/master/design-documents/graph-ql/coverage

ishakhsuvarov

I've filed an issue #2557 to take one more look at the copy-pasted code in the future

al.kravchuk added 3 commits July 27, 2019 10:54

MSI-2382 GraphQl support for In-Store Pickup [Mutation].

db06d29

Add simple module declaration.

MSI-2382 GraphQl support for In-Store Pickup [Mutation].

236f25c

Add parameter to SetShippingAddress mutation.

MSI-2382 GraphQl support for In-Store Pickup [Mutation].

e7c845d

Add api tests coverage.

magento-engcom-team added Partner: ISM eCompany partners-contribution labels Jul 28, 2019

swnsma added Store Pickup and removed Partner: ISM eCompany partners-contribution labels Jul 28, 2019

swnsma added this to the Store Pickup Support milestone Jul 28, 2019

swnsma assigned ishakhsuvarov Jul 28, 2019

swnsma requested a review from ishakhsuvarov July 28, 2019 07:42

m2-community-project bot added the Progress: review label Jul 28, 2019

MSI-2382 GraphQl support for In-Store Pickup [Mutation].

2df8f11

Fix static tests.

swnsma requested a review from naydav July 28, 2019 08:25

al.kravchuk added 2 commits August 2, 2019 13:50

MSI-2382-GraphQl-support-for-In-Store-Pickup-Mutation.

1e37b45

Fix bug with deletion of address pickup locatio .

MSI-2382-GraphQl-support-for-In-Store-Pickup-Mutation.

da17973

Add Pickup Location to Quote Shipping Address Graph Ql Schema. Fix adding of Pickup Location Code to Shipping Address.

swnsma added Partner: ISM eCompany partners-contribution labels Aug 2, 2019

al.kravchuk and others added 3 commits August 9, 2019 20:06

Merge branch 'store-pickup' into MSI-2382-GraphQl-support-for-In-Stor…

4ca5b5f

…e-Pickup-Mutation

Fix php version in composer.json

90db7e8

Update schema.graphqls

df172bb

ishakhsuvarov suggested changes Aug 28, 2019

View reviewed changes

Merge branch 'store-pickup' of github.com:magento/inventory into MSI-…

9ec9cf8

…2382-GraphQl-support-for-In-Store-Pickup-Mutation Conflicts: composer.lock

ishakhsuvarov reviewed Aug 28, 2019

View reviewed changes

lenaorobei reviewed Aug 28, 2019

View reviewed changes

...gento/InventoryInStorePickupQuoteGraphQl/Test/Api/Customer/PickupLocationForShippingTest.php Show resolved Hide resolved

m2-community-project bot assigned lenaorobei Aug 28, 2019

lenaorobei reviewed Aug 28, 2019

View reviewed changes

.../Magento/InventoryInStorePickupQuoteGraphQl/Test/Api/Guest/PickupLocationForShippingTest.php Show resolved Hide resolved

lenaorobei reviewed Aug 28, 2019

View reviewed changes

app/code/Magento/InventoryInStorePickupQuoteGraphQl/etc/schema.graphqls Show resolved Hide resolved

ishakhsuvarov suggested changes Aug 28, 2019

View reviewed changes

m2-community-project bot assigned swnsma Aug 29, 2019

al.kravchuk added 2 commits August 29, 2019 10:58

Msi 2382 graph ql support for in store pickup mutation.

57a39ab

Apply code review changes.

Merge branch 'MSI-2382-GraphQl-support-for-In-Store-Pickup-Mutation' …

7b3296d

…of github.com:magento-engcom/msi into MSI-2382-GraphQl-support-for-In-Store-Pickup-Mutation

Merge branch 'store-pickup' of github.com:magento/inventory into MSI-…

e6ce33f

…2382-GraphQl-support-for-In-Store-Pickup-Mutation

ishakhsuvarov removed this from the Store Pickup Support milestone Sep 10, 2019

al.kravchuk added 3 commits September 11, 2019 19:08

Merge branch 'store-pickup' into MSI-2382-GraphQl-support-for-In-Stor…

3be80d3

…e-Pickup-Mutation

MSI-2382 GraphQl support for In-Store Pickup [Mutation].

661dae6

Fix Pickup Location missed for created order.

Merge branch 'MSI-2382-GraphQl-support-for-In-Store-Pickup-Mutation' …

e3b4c68

…of github.com:magento-engcom/msi into MSI-2382-GraphQl-support-for-In-Store-Pickup-Mutation

swnsma mentioned this pull request Sep 12, 2019

Cart operations GraphQl Schema actualization and in store pickup support magento/architecture#274

Merged

ishakhsuvarov mentioned this pull request Sep 12, 2019

Investigate code duplication can be avoided #2557

Closed

ishakhsuvarov approved these changes Sep 12, 2019

View reviewed changes

ishakhsuvarov merged commit 27c9acd into store-pickup Sep 12, 2019

ishakhsuvarov added Award: advanced Award: category of expertise Award: special achievement Award: test coverage labels Sep 13, 2019

ishakhsuvarov deleted the MSI-2382-GraphQl-support-for-In-Store-Pickup-Mutation branch September 16, 2019 19:44

swnsma mentioned this pull request Sep 22, 2019

Add shipping address input extension magento/graphql-ce#955

Merged

4 tasks

	class SetShippingAddressesOnCart implements SetShippingAddressesOnCartInterface
	class SetShippingAddressesToCart implements SetShippingAddressesToCartInterface

Msi 2382 graph ql support for in store pickup mutation #2427

Msi 2382 graph ql support for in store pickup mutation #2427

Uh oh!

Conversation

swnsma commented Jul 28, 2019

Description

Uh oh!

swnsma commented Jul 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishakhsuvarov commented Jul 29, 2019

Uh oh!

ishakhsuvarov Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

swnsma Aug 29, 2019

Choose a reason for hiding this comment

Uh oh!

ishakhsuvarov Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

swnsma Aug 29, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ishakhsuvarov Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

swnsma Aug 29, 2019

Choose a reason for hiding this comment

Uh oh!

ishakhsuvarov Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

swnsma Aug 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ishakhsuvarov left a comment

Choose a reason for hiding this comment

Uh oh!

swnsma commented Aug 29, 2019

Uh oh!

lenaorobei commented Sep 11, 2019

Uh oh!

ishakhsuvarov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

swnsma commented Jul 28, 2019 •

edited

Loading

swnsma Aug 29, 2019 •

edited

Loading